Drag on linux

ui/base/x/selection_owner.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/base/x/selection_owner.h"
 
 #include <X11/Xlib.h>
 #include <X11/Xatom.h>
 
 #include "base/logging.h"
@@ skipping 17 matching lines @@
 SelectionOwner::SelectionOwner(Display* x_display,
                                Window x_window,
                                Atom selection_name)
     : x_display_(x_display),
       x_window_(x_window),
       selection_name_(selection_name),
       atom_cache_(x_display_, kAtomsToCache) {
 }
 
 SelectionOwner::~SelectionOwner() {
+  Clear();
+}
+
+void SelectionOwner::RetrieveTargets(std::vector<Atom>* targets) {

[Daniel Erat, 2013/06/17 22:09:57]

nit: either clear |targets| first here or document in the header that this
appends to it

+  for (SelectionFormatMap::const_iterator it = selection_data_->begin();
+       it != selection_data_->end(); ++it) {
+    targets->push_back(it->first);
+  }
 }
 
 void SelectionOwner::TakeOwnershipOfSelection(
     scoped_ptr<SelectionFormatMap> data) {
   XSetSelectionOwner(x_display_, selection_name_, x_window_, CurrentTime);
 
   if (XGetSelectionOwner(x_display_, selection_name_) == x_window_) {
     // The X server agrees that we are the selection owner. Commit our data.
     selection_data_ = data.Pass();
   }
@@ skipping 18 matching lines @@
   reply.xselection.time = event.time;
 
   // Get the proper selection.
   if (selection_data_.get()) {
     Atom targets_atom = atom_cache_.GetAtom(kTargets);
     if (event.target == targets_atom) {
       // We have been asked for TARGETS. Send an atom array back with the data
       // types we support.
       std::vector<Atom> targets;
       targets.push_back(targets_atom);
-      for (SelectionFormatMap::const_iterator it = selection_data_->begin();
-           it != selection_data_->end(); ++it) {
-        targets.push_back(it->first);
-      }
+      RetrieveTargets(&targets);
 
       XChangeProperty(x_display_, event.requestor, event.property, XA_ATOM, 32,
                       PropModeReplace,
                       reinterpret_cast<unsigned char*>(&targets.front()),
                       targets.size());
       reply.xselection.property = event.property;
     } else if (event.target == atom_cache_.GetAtom(kMultiple)) {
       // TODO(erg): Theoretically, the spec claims I'm supposed to handle the
       // MULTIPLE case, but I haven't seen it in the wild yet.
       NOTIMPLEMENTED();
@@ skipping 23 matching lines @@
 
 void SelectionOwner::OnSelectionClear(const XSelectionClearEvent& event) {
   DLOG(ERROR) << "SelectionClear";
 
   // TODO(erg): If we receive a SelectionClear event while we're handling data,
   // we need to delay clearing.
 }
 
 }  // namespace ui