Implement pepper interface and plumbing for HRD's UI on ChromeOS

chrome/browser/renderer_host/pepper/pepper_talk_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_host/pepper/pepper_talk_host.h"
 
 #include "base/bind.h"
 #include "content/public/browser/browser_ppapi_host.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/render_view_host.h"
 #include "grit/generated_resources.h"
 #include "ppapi/c/pp_errors.h"
+#include "ppapi/host/dispatch_host_message.h"
 #include "ppapi/host/host_message_context.h"
 #include "ppapi/host/ppapi_host.h"
 #include "ppapi/proxy/ppapi_messages.h"
 #include "ui/base/l10n/l10n_util.h"
 
 #if defined(USE_ASH)
 #include "ash/shell.h"
 #include "ash/shell_window_ids.h"
 #include "chrome/browser/ui/simple_message_box.h"
 #include "ui/aura/window.h"
@@ skipping 45 matching lines @@
       weak_factory_(this),
       browser_ppapi_host_(host) {
 }
 
 PepperTalkHost::~PepperTalkHost() {
 }
 
 int32_t PepperTalkHost::OnResourceMessageReceived(
     const IPC::Message& msg,
     ppapi::host::HostMessageContext* context) {
-  // We only have one message with no parameters.
-  if (msg.type() != PpapiHostMsg_Talk_GetPermission::ID)
-    return 0;
+  IPC_BEGIN_MESSAGE_MAP(PepperTalkHost, msg)
+    PPAPI_DISPATCH_HOST_RESOURCE_CALL(PpapiHostMsg_Talk_RequestPermission,
+                                      OnRequestPermission)
+  IPC_END_MESSAGE_MAP()
+  return PP_ERROR_FAILED;

[Josh Horwich, 2013/06/04 19:48:37]

Curious - we used to return 0 here for unknown messages, now it's
PP_ERROR_FAILED. Was the old code just wrong, or should we continue returning 0?

[dcaiafa, 2013/06/04 22:38:15]

I'm not an expert, but every other host in this directory returns
PP_ERROR_FAILED (PepperBrokerMessageFilter, PeppperFlashBrowserHost,
PepperFlashDRMHost, etc).

On 2013/06/04 19:48:37, Josh Horwich wrote:

+}
+
+int32_t PepperTalkHost::OnRequestPermission(
+    ppapi::host::HostMessageContext* context,
+    PP_TalkPermission permission) {
+  // TODO(dcaiafa): Implement support for other permission types.
+  if (permission != PP_TALKPERMISSION_SCREENCAST)
+    return PP_ERROR_BADARGUMENT;
 
   int render_process_id = 0;
   int render_view_id = 0;
   browser_ppapi_host_->GetRenderViewIDsForInstance(
       pp_instance(), &render_process_id, &render_view_id);
 
   content::BrowserThread::PostTaskAndReplyWithResult(
       content::BrowserThread::UI, FROM_HERE,
       base::Bind(&GetPermissionOnUIThread, render_process_id, render_view_id,
                  context->MakeReplyMessageContext()),
       base::Bind(&PepperTalkHost::GotTalkPermission,
                  weak_factory_.GetWeakPtr()));
   return PP_OK_COMPLETIONPENDING;
 }
 
 void PepperTalkHost::GotTalkPermission(
     ppapi::host::ReplyMessageContext reply) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));
-  host()->SendReply(reply, PpapiPluginMsg_Talk_GetPermissionReply());
+  host()->SendReply(reply, PpapiPluginMsg_Talk_RequestPermissionReply());
 }
 
 }  // namespace chrome