chrome/test/data/extensions/api_test/cross_origin_xhr/background_page/test.js - Issue 16268017: GTTF: convert some tests in chrome to use EmbeddedTestServer patch nr 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/cross_origin_xhr/background_page/test.js

Issue 16268017: GTTF: convert some tests in chrome to use EmbeddedTestServer patch nr 1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/cross_origin_xhr/all_urls/test.js ('k') | chrome/test/data/extensions/api_test/cross_origin_xhr/content_script/test.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/cross_origin_xhr/background_page/test.js

diff --git a/chrome/test/data/extensions/api_test/cross_origin_xhr/background_page/test.js b/chrome/test/data/extensions/api_test/cross_origin_xhr/background_page/test.js

index 77288c2498adeda3814f9193a29b31825ba0816c..a3e92119b0c5c15e524778a84f8475a7150a8bd6 100644

--- a/chrome/test/data/extensions/api_test/cross_origin_xhr/background_page/test.js

+++ b/chrome/test/data/extensions/api_test/cross_origin_xhr/background_page/test.js

@@ -6,7 +6,7 @@ chrome.test.getConfig(function(config) {

function doReq(domain, expectSuccess) {

var req = new XMLHttpRequest();

- var url = domain + ":PORT/files/extensions/test_file.txt";

+ var url = domain + ":PORT/extensions/test_file.txt";

url = url.replace(/PORT/, config.testServer.port);

chrome.test.log("Requesting url: " + url);

@@ -53,8 +53,9 @@ chrome.test.getConfig(function(config) {

function disallowedSubdomain() {

doReq("http://foob.com", false);

- function disallowedSSL() {

- doReq("https://a.com", false);

- }

+ // TODO(asargent): Explicitly create SSL test server and enable the test.

+ // function disallowedSSL() {

+ // doReq("https://a.com", false);

+ // }

]);

});