chrome/browser/extensions/api/proxy/proxy_apitest.cc - Issue 16268017: GTTF: convert some tests in chrome to use EmbeddedTestServer patch nr 1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/proxy/proxy_apitest.cc

Issue 16268017: GTTF: convert some tests in chrome to use EmbeddedTestServer patch nr 1 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/permissions/permissions_apitest.cc ('k') | chrome/browser/extensions/api/runtime/runtime_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/proxy/proxy_apitest.cc

diff --git a/chrome/browser/extensions/api/proxy/proxy_apitest.cc b/chrome/browser/extensions/api/proxy/proxy_apitest.cc

index be76c4006fbe6fce1e88a704dd9637f348b1628d..a05e71a27587e6e1435065ac4dbd4855b6d30721 100644

--- a/chrome/browser/extensions/api/proxy/proxy_apitest.cc

+++ b/chrome/browser/extensions/api/proxy/proxy_apitest.cc

@@ -283,7 +283,7 @@ IN_PROC_BROWSER_TEST_F(ProxySettingsApiTest,

// Tests error events: invalid proxy

IN_PROC_BROWSER_TEST_F(ProxySettingsApiTest, MAYBE_ProxyEventsInvalidProxy) {

- ASSERT_TRUE(StartTestServer());

+ ASSERT_TRUE(StartEmbeddedTestServer());

ASSERT_TRUE(

RunExtensionSubtest("proxy/events", "invalid_proxy.html")) << message_;

}