DevTools: fix for open-close-open.html test

content/shell/renderer/webkit_test_runner.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/shell/renderer/webkit_test_runner.h"
 
 #include <algorithm>
 #include <clocale>
 #include <cmath>
 
@@ skipping 347 matching lines @@
   if (!new_size.isEmpty())
     ForceResizeRenderView(render_view(), new_size);
 }
 
 void WebKitTestRunner::showDevTools() {
   Send(new ShellViewHostMsg_ShowDevTools(routing_id()));
 }
 
 void WebKitTestRunner::closeDevTools() {
   Send(new ShellViewHostMsg_CloseDevTools(routing_id()));
+  WebDevToolsAgent* agent = render_view()->GetWebView()->devToolsAgent();
+  if (agent)
+    agent->detach();

[yurys, 2013/06/06 09:28:23]

How was it called before when front-end was closing? Don't we need to fix that
place too?

[yurys, 2013/06/06 09:35:41]

Looks like WebDevToolsAgentImpl::detach() should check if front-end is still
attached. Also it seems that there can be a race:
1. First front-end close is started
2. New front-end attached.
3. Detach event is received from the first front-end and current front-end (the
new one) is cleared
 or am I missing something?

 }
 
 void WebKitTestRunner::evaluateInWebInspector(long call_id,
                                               const std::string& script) {
   WebDevToolsAgent* agent = render_view()->GetWebView()->devToolsAgent();
   if (agent)
     agent->evaluateInWebInspector(call_id, WebString::fromUTF8(script));
 }
 
 void WebKitTestRunner::clearAllDatabases() {
@@ skipping 340 matching lines @@
       ->loadRequest(WebURLRequest(GURL("about:blank")));
   Send(new ShellViewHostMsg_ResetDone(routing_id()));
 }
 
 void WebKitTestRunner::OnNotifyDone() {
   render_view()->GetWebView()->mainFrame()->executeScript(
       WebScriptSource(WebString::fromUTF8("testRunner.notifyDone();")));
 }
 
 }  // namespace content