Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 16267005: [oilpan] Add checks to new operator

Created:
7 years, 6 months ago by Erik Corry
Modified:
7 years, 6 months ago
CC:
blink-reviews, haraken, adamk+oilpan_chromium.org, Mads Ager (chromium), abarth-chromium
Visibility:
Public.

Description

[oilpan] Add checks to new operator Check in the new operator that the size matches the class on which the template is specialized. This is a prerequisite for the next stage where the allocator (via template specialization) knows enough about the type it is allocating to be able to visit it if there is a GC before it is adopted. R=ager@chromium.org, vegorov@chromium.org BUG=

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -0 lines) Patch
M Source/core/css/CSSValue.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/WebKitCSSFilterValue.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/css/WebKitCSSTransformValue.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/Element.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/dom/Node.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/heap/Heap.h View 1 chunk +26 lines, -0 lines 1 comment Download
M Source/heap/tests/HeapTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Erik Corry
7 years, 6 months ago (2013-06-10 19:29:10 UTC) #1
Mads Ager (chromium)
7 years, 6 months ago (2013-06-11 06:42:43 UTC) #2
I wonder if there is anything we can do that is less intrusive? Having to
override new with these macros (even in cases where everything is OK) is not
very nice.

https://codereview.chromium.org/16267005/diff/1/Source/heap/Heap.h
File Source/heap/Heap.h (right):

https://codereview.chromium.org/16267005/diff/1/Source/heap/Heap.h#newcode445
Source/heap/Heap.h:445: // If this assert fails then you are inheriting this
method instead of
This comment seems to belong on the inherited new operator in the public section
below. Then this macro should have a comment about when to use it similar to the
one for OVERRIDE_NEW_ALL_SUBCLASSES_HAVE_DYNAMIC_ACCEPT.

Powered by Google App Engine
This is Rietveld 408576698