Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Side by Side Diff: content/test/test_render_view_host_factory.h

Issue 16267002: Re-fix http://crbug.com/87176, and add a test. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Much shorter test Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_TEST_TEST_RENDER_VIEW_HOST_FACTORY_H_ 5 #ifndef CONTENT_TEST_TEST_RENDER_VIEW_HOST_FACTORY_H_
6 #define CONTENT_TEST_TEST_RENDER_VIEW_HOST_FACTORY_H_ 6 #define CONTENT_TEST_TEST_RENDER_VIEW_HOST_FACTORY_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "content/browser/renderer_host/render_view_host_factory.h" 10 #include "content/browser/renderer_host/render_view_host_factory.h"
(...skipping 19 matching lines...) Expand all
30 virtual RenderViewHost* CreateRenderViewHost( 30 virtual RenderViewHost* CreateRenderViewHost(
31 SiteInstance* instance, 31 SiteInstance* instance,
32 RenderViewHostDelegate* delegate, 32 RenderViewHostDelegate* delegate,
33 RenderWidgetHostDelegate* widget_delegate, 33 RenderWidgetHostDelegate* widget_delegate,
34 int routing_id, 34 int routing_id,
35 int main_frame_routing_id, 35 int main_frame_routing_id,
36 bool swapped_out, 36 bool swapped_out,
37 SessionStorageNamespace* session_storage) OVERRIDE; 37 SessionStorageNamespace* session_storage) OVERRIDE;
38 38
39 private: 39 private:
40 // This is a bit of a hack. With the current design of the site instances /
41 // browsing instances, it's difficult to pass a RenderProcessHostFactory
42 // around properly.
43 //
44 // Instead, we set it right before we create a new RenderViewHost, which
45 // happens before the RenderProcessHost is created. This way, the instance
46 // has the correct factory and creates our special RenderProcessHosts.
47 RenderProcessHostFactory* render_process_host_factory_;
48
49 DISALLOW_COPY_AND_ASSIGN(TestRenderViewHostFactory); 40 DISALLOW_COPY_AND_ASSIGN(TestRenderViewHostFactory);
50 }; 41 };
51 42
52 } // namespace content 43 } // namespace content
53 44
54 #endif // CONTENT_TEST_TEST_RENDER_VIEW_HOST_FACTORY_H_ 45 #endif // CONTENT_TEST_TEST_RENDER_VIEW_HOST_FACTORY_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698