Separate prefs from HttpServerPropertiesManager.

Separate prefs from HttpServerPropertiesManager.

This is in preparation for moving prefs out of base. The property manager now
has a delegate interface that can be mocked more easily, hides the prefs path
name, and can easily be backed by Chrome prefs.

Committed: https://crrev.com/73172fb8462566ad1982e0bbad7bbf6639c9e66d
Cr-Commit-Position: refs/heads/master@{#371376}

[brettw, 2016-01-22 23:23:22]

brettw@chromium.org changed reviewers:
+ rtenneti@chromium.org

[brettw, 2016-01-22 23:23:26]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-22 23:23:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1626673002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1626673002/1

[brettw, 2016-01-22 23:24:45]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-22 23:26:51]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1626673002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1626673002/20001

[commit-bot: I haz the power, 2016-01-22 23:41:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-22 23:41:57]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[ramant (doing other things), 2016-01-23 00:47:13]

Description was changed from

==========
Separate prefs from HttpServerPropertiesManager.

This is in preparation for moving prefs out of base. The property manager now
has a delegate interface that can be mocked more easily, hides the prefs path
name, and can easily be backed by Chrome prefs.
==========

to

==========
Separate prefs from HttpServerPropertiesManager.

This is in preparation for moving prefs out of base. The property manager now
has a delegate interface that can be mocked more easily, hides the prefs path
name, and can easily be backed by Chrome prefs.
==========

[ramant (doing other things), 2016-01-23 00:47:13]

rtenneti@chromium.org changed reviewers:
+ mef@chromium.org

[ramant (doing other things), 2016-01-23 00:47:29]

lgtm

+mef for cronet changes.

[ramant (doing other things), 2016-01-23 00:52:13]

On 2016/01/23 00:47:29, ramant wrote:
> lgtm
> 
> +mef for cronet changes.

Minor compiler errors in

../../ios/chrome/browser/net/http_server_properties_manager_factory.cc

[mef, 2016-01-23 18:19:01]

https://codereview.chromium.org/1626673002/diff/20001/components/cronet/andro...
File components/cronet/android/cronet_url_request_context_adapter.cc (right):

https://codereview.chromium.org/1626673002/diff/20001/components/cronet/andro...
components/cronet/android/cronet_url_request_context_adapter.cc:79: void
SetServerProperties(const base::Value& value) override {
Why is SetServerProperties taking base::Value, but GetServerProperties returning
DictionaryValue?

https://codereview.chromium.org/1626673002/diff/20001/components/cronet/andro...
components/cronet/android/cronet_url_request_context_adapter.cc:91: std::string
path_;
const?

https://codereview.chromium.org/1626673002/diff/20001/net/http/http_server_pr...
File net/http/http_server_properties_manager.h (right):

https://codereview.chromium.org/1626673002/diff/20001/net/http/http_server_pr...
net/http/http_server_properties_manager.h:69: virtual void
SetServerProperties(const base::Value& value) = 0;
Should this be symmetrical to SetServerProperties and take DictionaryValue?

[brettw, 2016-01-25 20:47:10]

https://codereview.chromium.org/1626673002/diff/20001/components/cronet/andro...
File components/cronet/android/cronet_url_request_context_adapter.cc (right):

https://codereview.chromium.org/1626673002/diff/20001/components/cronet/andro...
components/cronet/android/cronet_url_request_context_adapter.cc:79: void
SetServerProperties(const base::Value& value) override {
On 2016/01/23 18:19:00, mef wrote:
> Why is SetServerProperties taking base::Value, but GetServerProperties
returning
> DictionaryValue?

Good idea, done.

[brettw, 2016-01-25 20:47:14]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-01-25 20:47:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
rtenneti@chromium.org
Link to the patchset: https://codereview.chromium.org/1626673002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-01-25 20:50:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1626673002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1626673002/40001

[commit-bot: I haz the power, 2016-01-25 22:20:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-25 22:20:58]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[brettw, 2016-01-25 22:55:20]

NET_EXPORT

[brettw, 2016-01-25 22:55:21]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-01-25 22:55:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
rtenneti@chromium.org
Link to the patchset: https://codereview.chromium.org/1626673002/#ps60001
(title: "NET_EXPORT")

[commit-bot: I haz the power, 2016-01-25 22:57:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1626673002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1626673002/60001

[commit-bot: I haz the power, 2016-01-26 00:28:47]

Description was changed from

==========
Separate prefs from HttpServerPropertiesManager.

This is in preparation for moving prefs out of base. The property manager now
has a delegate interface that can be mocked more easily, hides the prefs path
name, and can easily be backed by Chrome prefs.
==========

to

==========
Separate prefs from HttpServerPropertiesManager.

This is in preparation for moving prefs out of base. The property manager now
has a delegate interface that can be mocked more easily, hides the prefs path
name, and can easily be backed by Chrome prefs.
==========

[commit-bot: I haz the power, 2016-01-26 00:28:48]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-01-26 00:30:28]

Description was changed from

==========
Separate prefs from HttpServerPropertiesManager.

This is in preparation for moving prefs out of base. The property manager now
has a delegate interface that can be mocked more easily, hides the prefs path
name, and can easily be backed by Chrome prefs.
==========

to

==========
Separate prefs from HttpServerPropertiesManager.

This is in preparation for moving prefs out of base. The property manager now
has a delegate interface that can be mocked more easily, hides the prefs path
name, and can easily be backed by Chrome prefs.

Committed: https://crrev.com/73172fb8462566ad1982e0bbad7bbf6639c9e66d
Cr-Commit-Position: refs/heads/master@{#371376}
==========

[commit-bot: I haz the power, 2016-01-26 00:30:29]

Patchset 4 (id:??) landed as
https://crrev.com/73172fb8462566ad1982e0bbad7bbf6639c9e66d
Cr-Commit-Position: refs/heads/master@{#371376}