Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 1626663002: Switched Cast builder to use GN. (Closed)

Created:
4 years, 11 months ago by alokp
Modified:
4 years, 11 months ago
Reviewers:
Dirk Pranke, slan
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switched Cast builder to use GN. BUG=577403 Committed: https://crrev.com/059e24c0c596ae9d958f82e93a3b458b25677ef5 Cr-Commit-Position: refs/heads/master@{#371657}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M tools/mb/mb_config.pyl View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
alokp
4 years, 11 months ago (2016-01-22 23:18:26 UTC) #2
Dirk Pranke
lgtm. that's exactly the needed change :). If you have any thoughts on how to ...
4 years, 11 months ago (2016-01-22 23:28:49 UTC) #3
alokp
The config file as you said is self explanatory. The issue was discovering this file. ...
4 years, 11 months ago (2016-01-22 23:32:24 UTC) #4
slan
lgtm woohoo!
4 years, 11 months ago (2016-01-22 23:34:04 UTC) #5
Dirk Pranke
On 2016/01/22 23:32:24, alokp wrote: > The config file as you said is self explanatory. ...
4 years, 11 months ago (2016-01-22 23:35:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1626663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1626663002/1
4 years, 11 months ago (2016-01-22 23:36:42 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/106041)
4 years, 11 months ago (2016-01-23 00:17:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1626663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1626663002/1
4 years, 11 months ago (2016-01-25 06:43:22 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/106283)
4 years, 11 months ago (2016-01-25 09:06:05 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1626663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1626663002/1
4 years, 11 months ago (2016-01-26 22:54:33 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-27 00:22:02 UTC) #17
commit-bot: I haz the power
4 years, 11 months ago (2016-01-27 00:23:48 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/059e24c0c596ae9d958f82e93a3b458b25677ef5
Cr-Commit-Position: refs/heads/master@{#371657}

Powered by Google App Engine
This is Rietveld 408576698