|
|
DescriptionSwitched Cast builder to use GN.
BUG=577403
Committed: https://crrev.com/059e24c0c596ae9d958f82e93a3b458b25677ef5
Cr-Commit-Position: refs/heads/master@{#371657}
Patch Set 1 #
Messages
Total messages: 19 (7 generated)
alokp@chromium.org changed reviewers: + dpranke@chromium.org, slan@chromium.org
lgtm. that's exactly the needed change :). If you have any thoughts on how to make that sort of thing better documented or discoverable, I'd be interested to hear them.
The config file as you said is self explanatory. The issue was discovering this file. I was looking for the documentation in chromium infrastructure pages.
lgtm woohoo!
The CQ bit was checked by alokp@chromium.org
On 2016/01/22 23:32:24, alokp wrote: > The config file as you said is self explanatory. The issue was discovering this > file. I was looking for the documentation in chromium infrastructure pages. Yeah, discovering this stuff is a challenge, and our docs don't do a great job of describing changes to infra-side stuff and changes to src-side stuff in an integrated way at all yet :(.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1626663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1626663002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by alokp@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1626663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1626663002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by alokp@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1626663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1626663002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Switched Cast builder to use GN. BUG=577403 ========== to ========== Switched Cast builder to use GN. BUG=577403 Committed: https://crrev.com/059e24c0c596ae9d958f82e93a3b458b25677ef5 Cr-Commit-Position: refs/heads/master@{#371657} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/059e24c0c596ae9d958f82e93a3b458b25677ef5 Cr-Commit-Position: refs/heads/master@{#371657} |