third_party/WebKit/Source/core/paint/PaintLayer.h - Issue 1626623002: Skip PaintPhaseDescendantBlockBackgroundsOnly phase if possible

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayer.h

Issue 1626623002: Skip PaintPhaseDescendantBlockBackgroundsOnly phase if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@FloatPhase

Patch Set: Rebase Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/BoxClipper.h ('k') | third_party/WebKit/Source/core/paint/PaintLayer.cpp » ('j') | third_party/WebKit/Source/core/paint/TableRowPainter.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/paint/PaintLayer.h

diff --git a/third_party/WebKit/Source/core/paint/PaintLayer.h b/third_party/WebKit/Source/core/paint/PaintLayer.h

index 3d5d315fd6ad1392f26458a2320cfb5ff8f7270b..1d4e092f0ae706e5cc406ade3349e0f010f4acdf 100644

--- a/third_party/WebKit/Source/core/paint/PaintLayer.h

+++ b/third_party/WebKit/Source/core/paint/PaintLayer.h

@@ -630,6 +630,9 @@ public:

bool needsPaintPhaseFloat() const { return m_needsPaintPhaseFloat; }

void setNeedsPaintPhaseFloat() { ASSERT(isSelfPaintingLayer()); m_needsPaintPhaseFloat = true; }

+ bool needsPaintPhaseDescendantBlockBackgrounds() const { return m_needsPaintPhaseDescendantBlockBackgrounds; }

+ void setNeedsPaintPhaseDescendantBlockBackgrounds() { ASSERT(isSelfPaintingLayer()); m_needsPaintPhaseDescendantBlockBackgrounds = true; }

PaintTiming* paintTiming();

private:

@@ -764,6 +767,7 @@ private:

unsigned m_needsPaintPhaseDescendantOutlines : 1;

unsigned m_needsPaintPhaseFloat : 1;

+ unsigned m_needsPaintPhaseDescendantBlockBackgrounds : 1;

LayoutBoxModelObject* m_layoutObject;