Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.cpp

Issue 1626623002: Skip PaintPhaseDescendantBlockBackgroundsOnly phase if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@FloatPhase
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintLayer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutBox.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.cpp b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
index b92a53a9225c12c13f1826426a96cc250128cba6..0f46d4d73f789debc6bb726893096afbec2f623a 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBox.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBox.cpp
@@ -1471,6 +1471,14 @@ PaintInvalidationReason LayoutBox::invalidatePaintIfNeeded(PaintInvalidationStat
if (isFloating())
paintInvalidationState.enclosingSelfPaintingLayer(*this).setNeedsPaintPhaseFloat();
+ if (hasBoxDecorationBackground()
+ // We also paint overflow controls in background phase.
+ || (hasOverflowClip() && scrollableArea()->hasOverflowControls())) {
+ PaintLayer& layer = paintInvalidationState.enclosingSelfPaintingLayer(*this);
+ if (layer.layoutObject() != this)
+ layer.setNeedsPaintPhaseDescendantBlockBackgrounds();
+ }
+
PaintInvalidationReason fullInvalidationReason = fullPaintInvalidationReason();
// If the current paint invalidation reason is PaintInvalidationDelayedFull, then this paint invalidation can delayed if the
// LayoutBox in question is not on-screen. The logic to decide whether this is appropriate exists at the site of the original
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/paint/PaintLayer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698