Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Side by Side Diff: third_party/WebKit/Source/core/paint/PaintLayer.h

Issue 1626623002: Skip PaintPhaseDescendantBlockBackgroundsOnly phase if possible (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@FloatPhase
Patch Set: Rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2003, 2009, 2012 Apple Inc. All rights reserved.
3 * Copyright (C) 2013 Intel Corporation. All rights reserved. 3 * Copyright (C) 2013 Intel Corporation. All rights reserved.
4 * 4 *
5 * Portions are Copyright (C) 1998 Netscape Communications Corporation. 5 * Portions are Copyright (C) 1998 Netscape Communications Corporation.
6 * 6 *
7 * Other contributors: 7 * Other contributors:
8 * Robert O'Callahan <roc+@cs.cmu.edu> 8 * Robert O'Callahan <roc+@cs.cmu.edu>
9 * David Baron <dbaron@fas.harvard.edu> 9 * David Baron <dbaron@fas.harvard.edu>
10 * Christian Biesinger <cbiesinger@web.de> 10 * Christian Biesinger <cbiesinger@web.de>
(...skipping 654 matching lines...) Expand 10 before | Expand all | Expand 10 after
665 665
666 // Used to skip PaintPhaseDescendantOutlinesOnly for layers that have never had descendant outlines. 666 // Used to skip PaintPhaseDescendantOutlinesOnly for layers that have never had descendant outlines.
667 // Once it's set we never clear it because it's not easy to track if all out lines have been removed. 667 // Once it's set we never clear it because it's not easy to track if all out lines have been removed.
668 bool needsPaintPhaseDescendantOutlines() const { return m_needsPaintPhaseDes cendantOutlines; } 668 bool needsPaintPhaseDescendantOutlines() const { return m_needsPaintPhaseDes cendantOutlines; }
669 void setNeedsPaintPhaseDescendantOutlines() { ASSERT(isSelfPaintingLayer()); m_needsPaintPhaseDescendantOutlines = true; } 669 void setNeedsPaintPhaseDescendantOutlines() { ASSERT(isSelfPaintingLayer()); m_needsPaintPhaseDescendantOutlines = true; }
670 670
671 // Similar to above, but for PaintPhaseFloat. 671 // Similar to above, but for PaintPhaseFloat.
672 bool needsPaintPhaseFloat() const { return m_needsPaintPhaseFloat; } 672 bool needsPaintPhaseFloat() const { return m_needsPaintPhaseFloat; }
673 void setNeedsPaintPhaseFloat() { ASSERT(isSelfPaintingLayer()); m_needsPaint PhaseFloat = true; } 673 void setNeedsPaintPhaseFloat() { ASSERT(isSelfPaintingLayer()); m_needsPaint PhaseFloat = true; }
674 674
675 bool needsPaintPhaseDescendantBlockBackgrounds() const { return m_needsPaint PhaseDescendantBlockBackgrounds; }
676 void setNeedsPaintPhaseDescendantBlockBackgrounds() { ASSERT(isSelfPaintingL ayer()); m_needsPaintPhaseDescendantBlockBackgrounds = true; }
677
675 PaintTiming* paintTiming(); 678 PaintTiming* paintTiming();
676 679
677 private: 680 private:
678 // Bounding box in the coordinates of this layer. 681 // Bounding box in the coordinates of this layer.
679 LayoutRect logicalBoundingBox() const; 682 LayoutRect logicalBoundingBox() const;
680 683
681 bool hasOverflowControls() const; 684 bool hasOverflowControls() const;
682 685
683 void dirtyAncestorChainHasSelfPaintingLayerDescendantStatus(); 686 void dirtyAncestorChainHasSelfPaintingLayerDescendantStatus();
684 687
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
806 809
807 // True if this layout layer just lost its grouped mapping due to the Compos itedLayerMapping being destroyed, 810 // True if this layout layer just lost its grouped mapping due to the Compos itedLayerMapping being destroyed,
808 // and we don't yet know to what graphics layer this Layer will be assigned. 811 // and we don't yet know to what graphics layer this Layer will be assigned.
809 unsigned m_lostGroupedMapping : 1; 812 unsigned m_lostGroupedMapping : 1;
810 813
811 unsigned m_needsRepaint : 1; 814 unsigned m_needsRepaint : 1;
812 unsigned m_previousPaintResult : 1; // PaintLayerPainter::PaintResult 815 unsigned m_previousPaintResult : 1; // PaintLayerPainter::PaintResult
813 816
814 unsigned m_needsPaintPhaseDescendantOutlines : 1; 817 unsigned m_needsPaintPhaseDescendantOutlines : 1;
815 unsigned m_needsPaintPhaseFloat : 1; 818 unsigned m_needsPaintPhaseFloat : 1;
819 unsigned m_needsPaintPhaseDescendantBlockBackgrounds : 1;
816 820
817 // These bitfields are part of ancestor/descendant dependent compositing inp uts. 821 // These bitfields are part of ancestor/descendant dependent compositing inp uts.
818 unsigned m_hasDescendantWithClipPath : 1; 822 unsigned m_hasDescendantWithClipPath : 1;
819 unsigned m_hasNonIsolatedDescendantWithBlendMode : 1; 823 unsigned m_hasNonIsolatedDescendantWithBlendMode : 1;
820 unsigned m_hasAncestorWithClipPath : 1; 824 unsigned m_hasAncestorWithClipPath : 1;
821 825
822 LayoutBoxModelObject* m_layoutObject; 826 LayoutBoxModelObject* m_layoutObject;
823 827
824 PaintLayer* m_parent; 828 PaintLayer* m_parent;
825 PaintLayer* m_previous; 829 PaintLayer* m_previous;
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
857 861
858 } // namespace blink 862 } // namespace blink
859 863
860 #ifndef NDEBUG 864 #ifndef NDEBUG
861 // Outside the WebCore namespace for ease of invocation from gdb. 865 // Outside the WebCore namespace for ease of invocation from gdb.
862 void showLayerTree(const blink::PaintLayer*); 866 void showLayerTree(const blink::PaintLayer*);
863 void showLayerTree(const blink::LayoutObject*); 867 void showLayerTree(const blink::LayoutObject*);
864 #endif 868 #endif
865 869
866 #endif // Layer_h 870 #endif // Layer_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698