Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(856)

Issue 16266010: Add -[NSView(CrDebugging) cr_recursiveDescription]. (Closed)

Created:
7 years, 6 months ago by Robert Sesek
Modified:
7 years, 6 months ago
Reviewers:
sail
CC:
chromium-reviews, sail+watch_chromium.org
Visibility:
Public.

Description

Add -[NSView(CrDebugging) cr_recursiveDescription]. I use this often and it'd just be nice to have. I put it in a !NDEBUG so that we don't actually ship this, since nobody should be calling this outside of a debugging context. R=sail@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203715

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -0 lines) Patch
A ui/base/cocoa/view_description.h View 1 chunk +21 lines, -0 lines 0 comments Download
A ui/base/cocoa/view_description.mm View 1 chunk +31 lines, -0 lines 0 comments Download
M ui/ui.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Robert Sesek
7 years, 6 months ago (2013-05-31 21:25:48 UTC) #1
sail
LGTM! Looks like I'm not the only one that does this :-P
7 years, 6 months ago (2013-05-31 23:00:06 UTC) #2
Robert Sesek
7 years, 6 months ago (2013-06-03 15:17:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r203715.

Powered by Google App Engine
This is Rietveld 408576698