Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 16266005: Remove tests for playing video in reverse, which is not supported in Blink (Closed)

Created:
7 years, 6 months ago by adamk
Modified:
7 years, 6 months ago
CC:
blink-reviews, eae+blinkwatch, ojan, scherkus (not reviewing)
Visibility:
Public.

Description

Remove tests for playing video in reverse, which is not supported in Blink These tests, being marked as [ Timeout ], do nothing but slow down test runs. If this feature is ever implemented, it'll be easy to resurrect these tests, as I'm attaching this patch to the feature bug. R=ojan@chromium.org BUG=33099 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151708

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -167 lines) Patch
M LayoutTests/TestExpectations View 2 chunks +0 lines, -6 lines 0 comments Download
D LayoutTests/media/video-reverse-play-duration.html View 1 chunk +0 lines, -66 lines 0 comments Download
D LayoutTests/media/video-reverse-play-duration-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/media/video-timeupdate-reverse-play.html View 1 chunk +0 lines, -62 lines 0 comments Download
D LayoutTests/media/video-timeupdate-reverse-play-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
adamk
7 years, 6 months ago (2013-05-31 20:34:57 UTC) #1
ojan
lgtm
7 years, 6 months ago (2013-05-31 20:37:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/16266005/1
7 years, 6 months ago (2013-06-03 18:08:46 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=8451
7 years, 6 months ago (2013-06-03 19:39:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adamk@chromium.org/16266005/1
7 years, 6 months ago (2013-06-03 20:17:42 UTC) #5
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 6 months ago (2013-06-04 00:04:16 UTC) #6
adamk
7 years, 6 months ago (2013-06-04 00:23:36 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r151708 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698