Issue 16266004: Change default to not use pthreads at startup (all calculations on main thread)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 16266004: Change default to not use pthreads at startup (all calculations on main thread) (Closed)

Created:
7 years, 6 months ago by nfullagar1

Modified:
7 years, 6 months ago

Reviewers:
Sam Clegg

CC:
chromium-reviews, binji

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Change default to not use pthreads at startup (all calculations on main thread) Replace mutex with atomic __sync_sub_and_fetch() for NaCl builds. Fix for num_threads_ in ~ThreadPool. BUG=none TEST=run manually R=sbc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203765

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -19 lines)			Patch
M	native_client_sdk/src/examples/demo/voronoi/threadpool.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	native_client_sdk/src/examples/demo/voronoi/threadpool.cc	View	1 2	4 chunks	+12 lines, -16 lines	0 comments	Download
M	native_client_sdk/src/examples/demo/voronoi/voronoi.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

nfullagar1

replaced pthread_mutex_lock & unlock with AutoLock. ptoml, thx.

7 years, 6 months ago (2013-06-03 17:26:12 UTC) #3

Sam Clegg

On 2013/06/03 17:26:12, nfullagar1 wrote: > replaced pthread_mutex_lock & unlock with AutoLock. ptoml, thx. Still ...

7 years, 6 months ago (2013-06-03 18:04:56 UTC) #4

nfullagar1

7 years, 6 months ago (2013-06-03 20:41:23 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r203765 (presubmit successful).