Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 1626543002: Add SK_SUPPORT_LEGACY_DRAWFILTER guard around calls to SkCanvas::(get|set)DrawFilter. (Closed)

Created:
4 years, 11 months ago by dogben
Modified:
4 years, 11 months ago
Reviewers:
f(malita)
CC:
reviews_skia.org, mtklein, jcgregorio
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add SK_SUPPORT_LEGACY_DRAWFILTER guard around calls to SkCanvas::(get|set)DrawFilter. Fixes Google3 dm build. (Can't enable SK_INTERNAL for Google3 dm without enabling it for all dependents.) GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1626543002 Committed: https://skia.googlesource.com/skia/+/1c2729c8bbb19ec60a0148e143ae6516faf452d6

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M gm/drawfilter.cpp View 2 chunks +3 lines, -0 lines 0 comments Download
M tests/CanvasStateTest.cpp View 2 chunks +4 lines, -0 lines 0 comments Download
M tests/CanvasTest.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/DrawFilterTest.cpp View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1626543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1626543002/1
4 years, 11 months ago (2016-01-22 17:07:32 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mips-Debug-Android-Trybot/builds/4761)
4 years, 11 months ago (2016-01-22 17:08:48 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1626543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1626543002/20001
4 years, 11 months ago (2016-01-22 17:22:32 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-22 17:38:01 UTC) #10
dogben
4 years, 11 months ago (2016-01-22 17:39:07 UTC) #12
f(malita)
lgtm
4 years, 11 months ago (2016-01-22 17:43:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1626543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1626543002/20001
4 years, 11 months ago (2016-01-22 17:44:35 UTC) #15
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 17:45:16 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://skia.googlesource.com/skia/+/1c2729c8bbb19ec60a0148e143ae6516faf452d6

Powered by Google App Engine
This is Rietveld 408576698