Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1369)

Issue 1626503002: [interpreter] Re-enable some tests that pass by now. (Closed)

Created:
4 years, 11 months ago by Michael Starzinger
Modified:
4 years, 11 months ago
Reviewers:
oth, rmcilroy
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Re-enable some tests that pass by now. These tests have been disabled while support for try-finally was work in progress. By now control flow is connected properly and the tests pass. R=oth@chromium.org BUG=v8:4674 LOG=n Committed: https://crrev.com/00b0a536855026ac214523cb122d01bf9a9c1553 Cr-Commit-Position: refs/heads/master@{#33474}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M test/cctest/cctest.status View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/mjsunit.status View 6 chunks +0 lines, -6 lines 0 comments Download
M test/test262/test262.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Michael Starzinger
4 years, 11 months ago (2016-01-22 16:15:51 UTC) #3
rmcilroy
lgtm. thanks!
4 years, 11 months ago (2016-01-22 17:08:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1626503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1626503002/1
4 years, 11 months ago (2016-01-22 17:09:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-22 17:10:15 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 17:11:22 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/00b0a536855026ac214523cb122d01bf9a9c1553
Cr-Commit-Position: refs/heads/master@{#33474}

Powered by Google App Engine
This is Rietveld 408576698