Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1626493002: DM: dump a zero-results .json file right at startup. (Closed)

Created:
4 years, 11 months ago by mtklein_C
Modified:
4 years, 11 months ago
Reviewers:
borenet, dogben, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

DM: dump a zero-results .json file right at startup. This way, if DM runs, the file will be there, even if it crashes before the first time we'd ordinarily write out the file (currently, any time the number of tasks remaining to do becomes evenly divisible by 500). BUG=skia:4839 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1626493002 Committed: https://skia.googlesource.com/skia/+/5286f0222ccb65ce1dbe235adc225b79057dd0ae

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M dm/DM.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1626493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1626493002/1
4 years, 11 months ago (2016-01-22 15:51:59 UTC) #3
mtklein_C
4 years, 11 months ago (2016-01-22 16:00:03 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-22 16:03:17 UTC) #8
dogben
lgtm
4 years, 11 months ago (2016-01-22 16:05:07 UTC) #9
borenet
On 2016/01/22 16:05:07, Ben Wagner wrote: > lgtm LGTM
4 years, 11 months ago (2016-01-22 16:14:16 UTC) #10
mtklein
On 2016/01/22 16:14:16, borenet wrote: > On 2016/01/22 16:05:07, Ben Wagner wrote: > > lgtm ...
4 years, 11 months ago (2016-01-22 16:17:26 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1626493002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1626493002/1
4 years, 11 months ago (2016-01-22 16:17:37 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 16:18:17 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/5286f0222ccb65ce1dbe235adc225b79057dd0ae

Powered by Google App Engine
This is Rietveld 408576698