Refactor swizzle names and types.

Refactor swizzle names and types.

  - Plant a flag to say "pretend all the inputs are RGBA".
    This is how libpng thinks.
    This is the opposite of what the implementation had been doing,
    so I've rearranged everything to reflect the new orientation.

  - Rewrite the names to be less mysterious looking.  No more Xs.

  - Make the src type uniformly const void*, to allow for 888 (RGB) srcs.

This should be performance and pixel neutral.  (Please revert if it's not.)

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1626463002
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Committed: https://skia.googlesource.com/skia/+/8bf7b79cf9776b4edb3f6810e5ab8c80c49d3480

[mtklein_C, 2016-01-22 15:12:09]

Description was changed from

==========
Refactor swizzle names and types.

  - Plant a flag to say "pretend all the inputs are RGBA".
    This is how libpng thinks.
    This is the opposite of what the implementation had been doing,
    so I've rearranged everything to reflect the new orientation.

  - Rewrite the names to be less mysterious looking.  No more Xs.

  - Make the src type uniformly const void*, to allow for 888 srcs.

BUG=skia:
==========

to

==========
Refactor swizzle names and types.

  - Plant a flag to say "pretend all the inputs are RGBA".
    This is how libpng thinks.
    This is the opposite of what the implementation had been doing,
    so I've rearranged everything to reflect the new orientation.

  - Rewrite the names to be less mysterious looking.  No more Xs.

  - Make the src type uniformly const void*, to allow for 888 srcs.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[mtklein_C, 2016-01-22 15:12:34]

Description was changed from

==========
Refactor swizzle names and types.

  - Plant a flag to say "pretend all the inputs are RGBA".
    This is how libpng thinks.
    This is the opposite of what the implementation had been doing,
    so I've rearranged everything to reflect the new orientation.

  - Rewrite the names to be less mysterious looking.  No more Xs.

  - Make the src type uniformly const void*, to allow for 888 srcs.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
Refactor swizzle names and types.

  - Plant a flag to say "pretend all the inputs are RGBA".
    This is how libpng thinks.
    This is the opposite of what the implementation had been doing,
    so I've rearranged everything to reflect the new orientation.

  - Rewrite the names to be less mysterious looking.  No more Xs.

  - Make the src type uniformly const void*, to allow for 888 srcs.

This should be performance and pixel neutral.  (Please revert if it's not.)

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[mtklein_C, 2016-01-22 15:13:50]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-22 15:13:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1626463002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1626463002/1

[mtklein_C, 2016-01-22 15:25:10]

Description was changed from

==========
Refactor swizzle names and types.

  - Plant a flag to say "pretend all the inputs are RGBA".
    This is how libpng thinks.
    This is the opposite of what the implementation had been doing,
    so I've rearranged everything to reflect the new orientation.

  - Rewrite the names to be less mysterious looking.  No more Xs.

  - Make the src type uniformly const void*, to allow for 888 srcs.

This should be performance and pixel neutral.  (Please revert if it's not.)

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
Refactor swizzle names and types.

  - Plant a flag to say "pretend all the inputs are RGBA".
    This is how libpng thinks.
    This is the opposite of what the implementation had been doing,
    so I've rearranged everything to reflect the new orientation.

  - Rewrite the names to be less mysterious looking.  No more Xs.

  - Make the src type uniformly const void*, to allow for 888 (RGB) srcs.

This should be performance and pixel neutral.  (Please revert if it's not.)

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

[mtklein_C, 2016-01-22 15:25:36]

mtklein@chromium.org changed reviewers:
+ msarett@google.com

[commit-bot: I haz the power, 2016-01-22 15:28:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-22 15:28:50]

Dry run: This issue passed the CQ dry run.

[msarett, 2016-01-22 15:35:08]

LGTM

Thanks for doing the refactor!  I don't envy you.

https://codereview.chromium.org/1626463002/diff/1/src/opts/SkSwizzler_opts.h
File src/opts/SkSwizzler_opts.h (left):

https://codereview.chromium.org/1626463002/diff/1/src/opts/SkSwizzler_opts.h#...
src/opts/SkSwizzler_opts.h:15: // These variable names in these functions just
pretend the input is BGRA.
I find this comment to still be useful?  There is one BGRA user (yes it's BMP
:)).

[mtklein, 2016-01-22 15:39:52]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2016-01-22 15:39:52]

https://codereview.chromium.org/1626463002/diff/1/src/opts/SkSwizzler_opts.h
File src/opts/SkSwizzler_opts.h (left):

https://codereview.chromium.org/1626463002/diff/1/src/opts/SkSwizzler_opts.h#...
src/opts/SkSwizzler_opts.h:15: // These variable names in these functions just
pretend the input is BGRA.
On 2016/01/22 15:35:08, msarett wrote:
> I find this comment to still be useful?  There is one BGRA user (yes it's BMP
> :)).

Sort of... now that the order and the function names agree with each other, do
we really need to say that here?
    // The variable names in these functions follow the byte-order convention
established by the function names.
That should be implicit in most code.

If we put a comment like this anywhere, it'd probably be a reminder in SkOpts.h,
e.g. that BGRA_to_RGBA is the same as RGBA_to_BGRA?  It almost seems too
obvious?

[msarett, 2016-01-22 15:40:51]

https://codereview.chromium.org/1626463002/diff/1/src/opts/SkSwizzler_opts.h
File src/opts/SkSwizzler_opts.h (left):

https://codereview.chromium.org/1626463002/diff/1/src/opts/SkSwizzler_opts.h#...
src/opts/SkSwizzler_opts.h:15: // These variable names in these functions just
pretend the input is BGRA.
On 2016/01/22 15:39:52, mtklein wrote:
> On 2016/01/22 15:35:08, msarett wrote:
> > I find this comment to still be useful?  There is one BGRA user (yes it's
BMP
> > :)).
> 
> Sort of... now that the order and the function names agree with each other, do
> we really need to say that here?
>     // The variable names in these functions follow the byte-order convention
> established by the function names.
> That should be implicit in most code.
> 
> If we put a comment like this anywhere, it'd probably be a reminder in
SkOpts.h,
> e.g. that BGRA_to_RGBA is the same as RGBA_to_BGRA?  It almost seems too
> obvious?

Agreed that it's obvious.  Let's drop it.

[mtklein_C, 2016-01-22 15:41:57]

The CQ bit was checked by mtklein@chromium.org

[commit-bot: I haz the power, 2016-01-22 15:42:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1626463002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1626463002/1

[commit-bot: I haz the power, 2016-01-22 15:42:55]

Description was changed from

==========
Refactor swizzle names and types.

  - Plant a flag to say "pretend all the inputs are RGBA".
    This is how libpng thinks.
    This is the opposite of what the implementation had been doing,
    so I've rearranged everything to reflect the new orientation.

  - Rewrite the names to be less mysterious looking.  No more Xs.

  - Make the src type uniformly const void*, to allow for 888 (RGB) srcs.

This should be performance and pixel neutral.  (Please revert if it's not.)

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot
==========

to

==========
Refactor swizzle names and types.

  - Plant a flag to say "pretend all the inputs are RGBA".
    This is how libpng thinks.
    This is the opposite of what the implementation had been doing,
    so I've rearranged everything to reflect the new orientation.

  - Rewrite the names to be less mysterious looking.  No more Xs.

  - Make the src type uniformly const void*, to allow for 888 (RGB) srcs.

This should be performance and pixel neutral.  (Please revert if it's not.)

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
CQ_EXTRA_TRYBOTS=client.skia:Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD-Trybot

Committed:
https://skia.googlesource.com/skia/+/8bf7b79cf9776b4edb3f6810e5ab8c80c49d3480
==========

[commit-bot: I haz the power, 2016-01-22 15:42:55]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8bf7b79cf9776b4edb3f6810e5ab8c80c49d3480