Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1626443002: Revert of Add gpu implementation of OverdrawXfermode (Closed)

Created:
4 years, 11 months ago by robertphillips
Modified:
4 years, 11 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Add gpu implementation of OverdrawXfermode (patchset #6 id:100001 of https://codereview.chromium.org/1607253002/ ) Reason for revert: Overdraw Xfer mode using new fangled glsl features Original issue's description: > Add gpu implementation of OverdrawXfermode > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1607253002 > > Committed: https://skia.googlesource.com/skia/+/8bc3cf88bbf5e5d5724356f076931bb70a6117ba TBR=egdaniel@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://skia.googlesource.com/skia/+/e429c88a811dfa05a26582a06fd53752768aa9f4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -406 lines) Patch
M debugger/QT/SkDebuggerGUI.cpp View 2 chunks +1 line, -1 line 0 comments Download
M debugger/QT/SkSettingsWidget.cpp View 1 chunk +3 lines, -9 lines 0 comments Download
M gyp/debugger.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M gyp/dm.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M gyp/gmslides.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M gyp/tests.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M src/effects/SkArithmeticMode.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M src/effects/SkArithmeticMode_gpu.cpp View 1 chunk +11 lines, -2 lines 0 comments Download
M src/gpu/GrProcessor.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrCustomXfermode.cpp View 1 chunk +11 lines, -2 lines 0 comments Download
M src/gpu/effects/GrPorterDuffXferProcessor.cpp View 1 chunk +11 lines, -2 lines 0 comments Download
M src/gpu/glsl/GrGLSLXferProcessor.h View 1 chunk +0 lines, -8 lines 0 comments Download
M src/gpu/glsl/GrGLSLXferProcessor.cpp View 1 chunk +0 lines, -18 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.cpp View 3 chunks +48 lines, -2 lines 0 comments Download
D src/utils/debugger/SkOverdrawMode.h View 1 chunk +0 lines, -25 lines 0 comments Download
D src/utils/debugger/SkOverdrawMode.cpp View 1 chunk +0 lines, -323 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
robertphillips
Created Revert of Add gpu implementation of OverdrawXfermode
4 years, 11 months ago (2016-01-22 14:27:42 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1626443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1626443002/1
4 years, 11 months ago (2016-01-22 14:27:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1626443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1626443002/1
4 years, 11 months ago (2016-01-22 14:32:21 UTC) #3
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 14:54:00 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e429c88a811dfa05a26582a06fd53752768aa9f4

Powered by Google App Engine
This is Rietveld 408576698