src/full-codegen/x64/full-codegen-x64.cc - Issue 1626423003: Support computed properties for ES2015 Function.name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/full-codegen/x64/full-codegen-x64.cc

Issue 1626423003: Support computed properties for ES2015 Function.name (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Merge to trunk, disable bytecode generator class test Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/full-codegen/x64/full-codegen-x64.cc

diff --git a/src/full-codegen/x64/full-codegen-x64.cc b/src/full-codegen/x64/full-codegen-x64.cc

index 470e5c6613cb7ffd56128fb1e0b9e41f569dbcc9..a5c3421223e84381f09bb77fbeca6e118ba17615 100644

--- a/src/full-codegen/x64/full-codegen-x64.cc

+++ b/src/full-codegen/x64/full-codegen-x64.cc

@@ -1588,7 +1588,8 @@ void FullCodeGenerator::VisitObjectLiteral(ObjectLiteral* expr) {

case ObjectLiteral::Property::COMPUTED:

if (property->emit_store()) {

__ Push(Smi::FromInt(NONE));

- __ CallRuntime(Runtime::kDefineDataPropertyUnchecked);

+ __ Push(Smi::FromInt(property->NeedsSetFunctionName()));

+ __ CallRuntime(Runtime::kDefineDataPropertyInLiteral);

} else {

__ Drop(3);

}

@@ -2287,7 +2288,9 @@ void FullCodeGenerator::EmitClassDefineProperties(ClassLiteral* lit) {

case ObjectLiteral::Property::PROTOTYPE:

UNREACHABLE();

case ObjectLiteral::Property::COMPUTED:

- __ CallRuntime(Runtime::kDefineClassMethod);

+ __ Push(Smi::FromInt(DONT_ENUM));

+ __ Push(Smi::FromInt(property->NeedsSetFunctionName()));

+ __ CallRuntime(Runtime::kDefineDataPropertyInLiteral);

break;

case ObjectLiteral::Property::GETTER:

« no previous file with comments | « src/full-codegen/ppc/full-codegen-ppc.cc ('k') | src/full-codegen/x87/full-codegen-x87.cc » ('j') | no next file with comments »