src/compiler/linkage.cc - Issue 1626423003: Support computed properties for ES2015 Function.name

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/linkage.cc

Issue 1626423003: Support computed properties for ES2015 Function.name (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Merge to trunk, disable bytecode generator class test Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/linkage.cc

diff --git a/src/compiler/linkage.cc b/src/compiler/linkage.cc

index 12a35b65132130297c42e3b716dd51cdb2d232ad..a3e936c0f499e49701e96d48dedd72ea4ba160ad 100644

--- a/src/compiler/linkage.cc

+++ b/src/compiler/linkage.cc

@@ -148,7 +148,7 @@ int Linkage::FrameStateInputCount(Runtime::FunctionId function) {

switch (function) {

case Runtime::kAllocateInTargetSpace:

case Runtime::kCreateIterResultObject:

- case Runtime::kDefineClassMethod: // TODO(jarin): Is it safe?

+ case Runtime::kDefineDataPropertyInLiteral:

case Runtime::kDefineGetterPropertyUnchecked: // TODO(jarin): Is it safe?

case Runtime::kDefineSetterPropertyUnchecked: // TODO(jarin): Is it safe?

case Runtime::kFinalizeClassDefinition: // TODO(conradw): Is it safe?

« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | src/full-codegen/arm/full-codegen-arm.cc » ('j') | no next file with comments »