Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Unified Diff: test/cctest/interpreter/test-bytecode-generator.cc

Issue 1626423003: Support computed properties for ES2015 Function.name (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Mostly working Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/interpreter/test-bytecode-generator.cc
diff --git a/test/cctest/interpreter/test-bytecode-generator.cc b/test/cctest/interpreter/test-bytecode-generator.cc
index af83799c50f02914d8d533e04411ca8858e3485c..2940eec2442ed7995ce738747fc21bec9970485b 100644
--- a/test/cctest/interpreter/test-bytecode-generator.cc
+++ b/test/cctest/interpreter/test-bytecode-generator.cc
@@ -3826,6 +3826,8 @@ TEST(ObjectLiterals) {
ObjectLiteral::kDisableMementos;
int deep_elements_flags =
ObjectLiteral::kFastElements | ObjectLiteral::kDisableMementos;
+
+ // clang-format off
ExpectedSnippet<InstanceType> snippets[] = {
{"return { };",
kPointerSize,
@@ -4030,9 +4032,9 @@ TEST(ObjectLiterals) {
1,
{InstanceType::FIXED_ARRAY_TYPE}},
{"var a = 'test'; return { [a]: 1 }",
- 6 * kPointerSize,
+ 7 * kPointerSize,
1,
- 33,
+ 36,
{
B(LdaConstant), U8(0), //
B(Star), R(0), //
@@ -4046,8 +4048,10 @@ TEST(ObjectLiterals) {
B(Star), R(4), //
B(LdaZero), //
B(Star), R(5), //
- B(CallRuntime), U16(Runtime::kDefineDataPropertyUnchecked), R(2), //
- U8(4), //
+ B(LdaZero), //
+ B(Star), R(6), //
+ B(CallRuntime), U16(Runtime::kDefineDataPropertyInLiteral), R(2), //
+ U8(5), //
B(Ldar), R(1), //
B(Return), //
},
@@ -4055,9 +4059,9 @@ TEST(ObjectLiterals) {
{InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
InstanceType::FIXED_ARRAY_TYPE}},
{"var a = 'test'; return { val: a, [a]: 1 }",
- 6 * kPointerSize,
+ 7 * kPointerSize,
1,
- 39,
+ 42,
{
B(LdaConstant), U8(0), //
B(Star), R(0), //
@@ -4073,8 +4077,10 @@ TEST(ObjectLiterals) {
B(Star), R(4), //
B(LdaZero), //
B(Star), R(5), //
- B(CallRuntime), U16(Runtime::kDefineDataPropertyUnchecked), R(2), //
- U8(4), //
+ B(LdaZero), //
+ B(Star), R(6), //
+ B(CallRuntime), U16(Runtime::kDefineDataPropertyInLiteral), R(2), //
+ U8(5), //
B(Ldar), R(1), //
B(Return), //
},
@@ -4083,9 +4089,9 @@ TEST(ObjectLiterals) {
InstanceType::FIXED_ARRAY_TYPE,
InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
{"var a = 'test'; return { [a]: 1, __proto__: {} }",
- 6 * kPointerSize,
+ 7 * kPointerSize,
1,
- 49,
+ 52,
{
B(LdaConstant), U8(0), //
B(Star), R(0), //
@@ -4099,8 +4105,10 @@ TEST(ObjectLiterals) {
B(Star), R(4), //
B(LdaZero), //
B(Star), R(5), //
- B(CallRuntime), U16(Runtime::kDefineDataPropertyUnchecked), R(2), //
- U8(4), //
+ B(LdaZero), //
+ B(Star), R(6), //
+ B(CallRuntime), U16(Runtime::kDefineDataPropertyInLiteral), R(2), //
+ U8(5), //
B(Mov), R(1), R(2), //
B(CreateObjectLiteral), U8(1), U8(0), U8(13), //
B(Star), R(4), //
@@ -4113,9 +4121,9 @@ TEST(ObjectLiterals) {
{InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE,
InstanceType::FIXED_ARRAY_TYPE}},
{"var n = 'name'; return { [n]: 'val', get a() { }, set a(b) {} };",
- 6 * kPointerSize,
+ 7 * kPointerSize,
1,
- 73,
+ 76,
{
B(LdaConstant), U8(0), //
B(Star), R(0), //
@@ -4129,8 +4137,10 @@ TEST(ObjectLiterals) {
B(Star), R(4), //
B(LdaZero), //
B(Star), R(5), //
- B(CallRuntime), U16(Runtime::kDefineDataPropertyUnchecked), R(2), //
- U8(4), //
+ B(LdaZero), //
+ B(Star), R(6), //
+ B(CallRuntime), U16(Runtime::kDefineDataPropertyInLiteral), R(2), //
+ U8(5), //
B(Mov), R(1), R(2), //
B(LdaConstant), U8(3), //
B(Star), R(3), //
@@ -4160,6 +4170,7 @@ TEST(ObjectLiterals) {
InstanceType::SHARED_FUNCTION_INFO_TYPE,
InstanceType::SHARED_FUNCTION_INFO_TYPE}},
};
+ // clang-format on
for (size_t i = 0; i < arraysize(snippets); i++) {
Handle<BytecodeArray> bytecode_array =

Powered by Google App Engine
This is Rietveld 408576698