Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: src/full-codegen/arm/full-codegen-arm.cc

Issue 1626423003: Support computed properties for ES2015 Function.name (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Mostly working Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/full-codegen/arm/full-codegen-arm.cc
diff --git a/src/full-codegen/arm/full-codegen-arm.cc b/src/full-codegen/arm/full-codegen-arm.cc
index 08934cbac3075017aa315d18403a5df62c063c98..5815e2137181a7c0c4bc7142e2b1eff13b629653 100644
--- a/src/full-codegen/arm/full-codegen-arm.cc
+++ b/src/full-codegen/arm/full-codegen-arm.cc
@@ -1651,7 +1651,8 @@ void FullCodeGenerator::VisitObjectLiteral(ObjectLiteral* expr) {
if (property->emit_store()) {
__ mov(r0, Operand(Smi::FromInt(NONE)));
adamk 2016/02/02 23:57:30 Let me know if you'd like me to change these to th
Toon Verwaest 2016/02/03 10:47:23 The Push cleanup sounds nice. As you prefer.
adamk 2016/02/03 19:04:59 Added the cleanup (within this switch statement, a
__ push(r0);
- __ CallRuntime(Runtime::kDefineDataPropertyUnchecked);
+ __ Push(Smi::FromInt(property->NeedsSetFunctionName()));
+ __ CallRuntime(Runtime::kDefineDataPropertyInLiteral);
} else {
__ Drop(3);
}
@@ -2393,7 +2394,10 @@ void FullCodeGenerator::EmitClassDefineProperties(ClassLiteral* lit) {
case ObjectLiteral::Property::PROTOTYPE:
UNREACHABLE();
case ObjectLiteral::Property::COMPUTED:
- __ CallRuntime(Runtime::kDefineClassMethod);
+ __ mov(r0, Operand(Smi::FromInt(DONT_ENUM)));
+ __ push(r0);
+ __ Push(Smi::FromInt(property->NeedsSetFunctionName()));
+ __ CallRuntime(Runtime::kDefineDataPropertyInLiteral);
break;
case ObjectLiteral::Property::GETTER:

Powered by Google App Engine
This is Rietveld 408576698