Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Side by Side Diff: src/full-codegen/mips/full-codegen-mips.cc

Issue 1626423003: Support computed properties for ES2015 Function.name (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Mostly working Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS 5 #if V8_TARGET_ARCH_MIPS
6 6
7 // Note on Mips implementation: 7 // Note on Mips implementation:
8 // 8 //
9 // The result_register() for mips is the 'v0' register, which is defined 9 // The result_register() for mips is the 'v0' register, which is defined
10 // by the ABI to contain function return values. However, the first 10 // by the ABI to contain function return values. However, the first
(...skipping 1630 matching lines...) Expand 10 before | Expand all | Expand 10 after
1641 EmitSetHomeObject(value, 2, property->GetSlot()); 1641 EmitSetHomeObject(value, 2, property->GetSlot());
1642 } 1642 }
1643 1643
1644 switch (property->kind()) { 1644 switch (property->kind()) {
1645 case ObjectLiteral::Property::CONSTANT: 1645 case ObjectLiteral::Property::CONSTANT:
1646 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 1646 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
1647 case ObjectLiteral::Property::COMPUTED: 1647 case ObjectLiteral::Property::COMPUTED:
1648 if (property->emit_store()) { 1648 if (property->emit_store()) {
1649 __ li(a0, Operand(Smi::FromInt(NONE))); 1649 __ li(a0, Operand(Smi::FromInt(NONE)));
1650 __ push(a0); 1650 __ push(a0);
1651 __ CallRuntime(Runtime::kDefineDataPropertyUnchecked); 1651 __ Push(Smi::FromInt(property->NeedsSetFunctionName()));
1652 __ CallRuntime(Runtime::kDefineDataPropertyInLiteral);
1652 } else { 1653 } else {
1653 __ Drop(3); 1654 __ Drop(3);
1654 } 1655 }
1655 break; 1656 break;
1656 1657
1657 case ObjectLiteral::Property::PROTOTYPE: 1658 case ObjectLiteral::Property::PROTOTYPE:
1658 UNREACHABLE(); 1659 UNREACHABLE();
1659 break; 1660 break;
1660 1661
1661 case ObjectLiteral::Property::GETTER: 1662 case ObjectLiteral::Property::GETTER:
(...skipping 714 matching lines...) Expand 10 before | Expand all | Expand 10 after
2376 if (NeedsHomeObject(value)) { 2377 if (NeedsHomeObject(value)) {
2377 EmitSetHomeObject(value, 2, property->GetSlot()); 2378 EmitSetHomeObject(value, 2, property->GetSlot());
2378 } 2379 }
2379 2380
2380 switch (property->kind()) { 2381 switch (property->kind()) {
2381 case ObjectLiteral::Property::CONSTANT: 2382 case ObjectLiteral::Property::CONSTANT:
2382 case ObjectLiteral::Property::MATERIALIZED_LITERAL: 2383 case ObjectLiteral::Property::MATERIALIZED_LITERAL:
2383 case ObjectLiteral::Property::PROTOTYPE: 2384 case ObjectLiteral::Property::PROTOTYPE:
2384 UNREACHABLE(); 2385 UNREACHABLE();
2385 case ObjectLiteral::Property::COMPUTED: 2386 case ObjectLiteral::Property::COMPUTED:
2386 __ CallRuntime(Runtime::kDefineClassMethod); 2387 __ li(a0, Operand(Smi::FromInt(DONT_ENUM)));
2388 __ push(a0);
2389 __ Push(Smi::FromInt(property->NeedsSetFunctionName()));
2390 __ CallRuntime(Runtime::kDefineDataPropertyInLiteral);
2387 break; 2391 break;
2388 2392
2389 case ObjectLiteral::Property::GETTER: 2393 case ObjectLiteral::Property::GETTER:
2390 __ li(a0, Operand(Smi::FromInt(DONT_ENUM))); 2394 __ li(a0, Operand(Smi::FromInt(DONT_ENUM)));
2391 __ push(a0); 2395 __ push(a0);
2392 __ CallRuntime(Runtime::kDefineGetterPropertyUnchecked); 2396 __ CallRuntime(Runtime::kDefineGetterPropertyUnchecked);
2393 break; 2397 break;
2394 2398
2395 case ObjectLiteral::Property::SETTER: 2399 case ObjectLiteral::Property::SETTER:
2396 __ li(a0, Operand(Smi::FromInt(DONT_ENUM))); 2400 __ li(a0, Operand(Smi::FromInt(DONT_ENUM)));
(...skipping 2398 matching lines...) Expand 10 before | Expand all | Expand 10 after
4795 reinterpret_cast<uint32_t>( 4799 reinterpret_cast<uint32_t>(
4796 isolate->builtins()->OsrAfterStackCheck()->entry())); 4800 isolate->builtins()->OsrAfterStackCheck()->entry()));
4797 return OSR_AFTER_STACK_CHECK; 4801 return OSR_AFTER_STACK_CHECK;
4798 } 4802 }
4799 4803
4800 4804
4801 } // namespace internal 4805 } // namespace internal
4802 } // namespace v8 4806 } // namespace v8
4803 4807
4804 #endif // V8_TARGET_ARCH_MIPS 4808 #endif // V8_TARGET_ARCH_MIPS
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698