Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 1626413002: Don't include <iostream>. (Closed)

Created:
4 years, 11 months ago by Nico
Modified:
4 years, 11 months ago
Reviewers:
dstockwell
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, mithro-old, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't needlessly include <iostream>. iostream contains a static initializer and generally should be frowned upon. It also makes presubmit fire when touching this file. (But after removing this, they complain about streams, so it doesn't really solve that problem.) BUG=none Committed: https://crrev.com/cab5d2ce24350f97e19a17e0ab70fe69ad710ed5 Cr-Commit-Position: refs/heads/master@{#371496}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/css/CSSValueTestHelper.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Nico
dstockwell: Your rietveld name still says "out until jan 5"
4 years, 11 months ago (2016-01-25 15:26:10 UTC) #2
dstockwell
lgtm
4 years, 11 months ago (2016-01-26 06:43:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1626413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1626413002/1
4 years, 11 months ago (2016-01-26 12:32:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 12:37:16 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 12:38:15 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cab5d2ce24350f97e19a17e0ab70fe69ad710ed5
Cr-Commit-Position: refs/heads/master@{#371496}

Powered by Google App Engine
This is Rietveld 408576698