Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 1626403003: Work around a location-related crash on OnePlus2 devices. (Closed)

Created:
4 years, 11 months ago by newt (away)
Modified:
4 years, 11 months ago
Reviewers:
Ted C
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Work around a location-related crash on OnePlus2 devices. On OnePlus2 Lollipop devices, the network location provider incorrectly requires the FINE_LOCATION permission, instead of just the COARSE_LOCATION permission. Those devices also allow users to disable location on a per-app basis, which leads to crashes when users disable fine location for Chrome, but not coarse location. This CL avoids a crash by checking both permissions on pre-M devices. BUG=580733 Committed: https://crrev.com/c13ab13e3dccb32be5a376b237a81ed326e158c0 Cr-Commit-Position: refs/heads/master@{#371409}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/omnibox/geo/GeolocationHeader.java View 2 chunks +18 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
newt (away)
PTAL
4 years, 11 months ago (2016-01-26 00:35:50 UTC) #2
Ted C
lgtm
4 years, 11 months ago (2016-01-26 00:46:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1626403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1626403003/1
4 years, 11 months ago (2016-01-26 00:55:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-26 01:41:28 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 01:42:19 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c13ab13e3dccb32be5a376b237a81ed326e158c0
Cr-Commit-Position: refs/heads/master@{#371409}

Powered by Google App Engine
This is Rietveld 408576698