Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: tools/android/loading/analyze.py

Issue 1626393002: tools/android/loading: ContentClassificationLens, ads and tracking requests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/android/loading/analyze.py
diff --git a/tools/android/loading/analyze.py b/tools/android/loading/analyze.py
index 27294d3801718eea09032f5bb091bdce70aaa248..5f15fe2320eb4fd01b8de8e07aa957ae00474e8e 100755
--- a/tools/android/loading/analyze.py
+++ b/tools/android/loading/analyze.py
@@ -24,6 +24,7 @@ sys.path.append(os.path.join(_SRC_DIR, 'build', 'android'))
import devil_chromium
from pylib import constants
+import content_classification_lens
import device_setup
import loading_model
import loading_trace
@@ -147,10 +148,14 @@ def _FullFetch(url, json_output, prefetch, local, prefetch_delay_seconds):
# TODO(mattcary): it would be nice to refactor so the --noads flag gets dealt
# with here.
-def _ProcessRequests(filename):
+def _ProcessRequests(filename, ad_rules_filename='',
+ tracking_rules_filename=''):
with open(filename) as f:
- return loading_model.ResourceGraph(
- loading_trace.LoadingTrace.FromJsonDict(json.load(f)))
+ trace = loading_trace.LoadingTrace.FromJsonDict(json.load(f))
+ content_lens = (
+ content_classification_lens.ContentClassificationLens.WithRulesFiles(
+ trace, ad_rules_filename, tracking_rules_filename))
+ return loading_model.ResourceGraph(trace, content_lens)
def InvalidCommand(cmd):
@@ -185,8 +190,11 @@ def DoPng(arg_str):
parser.add_argument('--eog', action='store_true')
parser.add_argument('--highlight')
parser.add_argument('--noads', action='store_true')
+ parser.add_argument('--ad_rules', default='')
+ parser.add_argument('--tracking_rules', default='')
args = parser.parse_args(arg_str)
- graph = _ProcessRequests(args.request_json)
+ graph = _ProcessRequests(
+ args.request_json, args.ad_rules, args.tracking_rules)
if args.noads:
graph.Set(node_filter=graph.FilterAds)
tmp = tempfile.NamedTemporaryFile()

Powered by Google App Engine
This is Rietveld 408576698