Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1626213002: Factor out encoded length calculation in AsyncResourceHandler (Closed)

Created:
4 years, 11 months ago by tzik
Modified:
4 years, 10 months ago
Reviewers:
kinuko
CC:
chromium-reviews, loading-reviews_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Factor out encoded length calculation in AsyncResourceHandler BUG=580928 Committed: https://crrev.com/75df24fa475917adfff5604b7b5b040ffd0d0e19 Cr-Commit-Position: refs/heads/master@{#372041}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -7 lines) Patch
M content/browser/loader/async_resource_handler.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/loader/async_resource_handler.cc View 1 3 chunks +9 lines, -7 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
tzik
PTAL
4 years, 11 months ago (2016-01-25 08:33:13 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1626213002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1626213002/1
4 years, 11 months ago (2016-01-25 08:33:29 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-01-25 09:36:08 UTC) #6
kinuko
lgtm
4 years, 10 months ago (2016-01-26 09:11:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1626213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1626213002/20001
4 years, 10 months ago (2016-01-27 03:57:00 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/14069)
4 years, 10 months ago (2016-01-27 05:54:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1626213002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1626213002/20001
4 years, 10 months ago (2016-01-28 05:53:54 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-01-28 07:13:27 UTC) #14
commit-bot: I haz the power
4 years, 10 months ago (2016-01-28 07:14:59 UTC) #16
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/75df24fa475917adfff5604b7b5b040ffd0d0e19
Cr-Commit-Position: refs/heads/master@{#372041}

Powered by Google App Engine
This is Rietveld 408576698