third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp - Issue 1625993004: [css-align] Avoid the style Reattach whenever align-items changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp

Issue 1625993004: [css-align] Avoid the style Reattach whenever align-items changes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Applied suggested changes. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutGrid.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp b/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp

index 8fc8befea55ac327cf423f04da6528a498fadb97..da39261c5890420f8e94426a3d8920552b262e91 100644

--- a/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/StyleAdjuster.cpp

@@ -296,16 +296,6 @@ void StyleAdjuster::adjustStyleForAlignment(ComputedStyle& style, const Computed

style.setAlignItemsPosition(ItemPositionStretch);

}

- // The 'auto' keyword computes to 'stretch' on absolutely-positioned elements,

- // and to the computed value of align-items on the parent (minus

- // any 'legacy' keywords) on all other boxes.

- if (style.alignSelfPosition() == ItemPositionAuto) {

- if (absolutePositioned)

- style.setAlignSelfPosition(ItemPositionStretch);

- else

- style.setAlignSelf(parentStyle.alignItems());

- }

// Block Containers: For table cells, the behavior of the 'auto' depends on the computed

// value of 'vertical-align', otherwise behaves as 'start'.

// Flex Containers: 'auto' computes to 'flex-start'.