Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 162593002: Updates the manifest file of Demo.app. (Closed)

Created:
6 years, 10 months ago by hirono
Modified:
6 years, 10 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, stevenjb+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org, mtomasz, rkc
Visibility:
Public.

Description

Updates the manifest file of Demo.app. We should update the manifest file as well as the contents of the extension in the chromeos image. BUG=342308 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250985

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/resources/chromeos/demo_app/manifest.json View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
hirono
PTAL the CL of Demo mode's manifest file? Thank you very much!
6 years, 10 months ago (2014-02-13 03:38:54 UTC) #1
xiyuan
LGTM Right, I forgot the manifest is here. :p
6 years, 10 months ago (2014-02-13 04:50:02 UTC) #2
hirono
On 2014/02/13 04:50:02, xiyuan wrote: > LGTM > > Right, I forgot the manifest is ...
6 years, 10 months ago (2014-02-13 04:53:49 UTC) #3
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 10 months ago (2014-02-13 04:53:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/162593002/1
6 years, 10 months ago (2014-02-13 04:55:08 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-13 06:16:00 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, cacheinvalidation_unittests, cc_unittests, check_deps, ...
6 years, 10 months ago (2014-02-13 06:16:01 UTC) #7
hirono
The CQ bit was checked by hirono@chromium.org
6 years, 10 months ago (2014-02-13 06:25:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/162593002/1
6 years, 10 months ago (2014-02-13 06:25:09 UTC) #9
commit-bot: I haz the power
6 years, 10 months ago (2014-02-13 14:26:05 UTC) #10
Message was sent while issue was closed.
Change committed as 250985

Powered by Google App Engine
This is Rietveld 408576698