Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: Source/bindings/scripts/unstable/v8_attributes.py

Issue 162583002: IDL compiler: sync Python to r167001 (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/unstable/v8_attributes.py
diff --git a/Source/bindings/scripts/unstable/v8_attributes.py b/Source/bindings/scripts/unstable/v8_attributes.py
index 1038eb33e1536cf7385135fa2e115b42cc0c6f62..9b4b3ffc65a6ecad77f3d1244b479f1b2c609a07 100644
--- a/Source/bindings/scripts/unstable/v8_attributes.py
+++ b/Source/bindings/scripts/unstable/v8_attributes.py
@@ -202,8 +202,6 @@ def getter_expression(interface, attribute, contents):
arguments.append('isNull')
if contents['is_getter_raises_exception']:
arguments.append('exceptionState')
- if attribute.idl_type == 'EventHandler':
- arguments.append('isolatedWorldForIsolate(info.GetIsolate())')
return '%s(%s)' % (getter_name, ', '.join(arguments))
@@ -298,19 +296,15 @@ def setter_expression(interface, attribute, contents):
arguments.append('imp')
idl_type = attribute.idl_type
if idl_type == 'EventHandler':
- # FIXME: pass the isolate instead of the isolated world
- isolated_world = 'isolatedWorldForIsolate(info.GetIsolate())'
getter_name = v8_utilities.scoped_name(interface, attribute, cpp_name(attribute))
- getter_arguments = arguments + [isolated_world]
contents['event_handler_getter_expression'] = '%s(%s)' % (
- getter_name, ', '.join(getter_arguments))
+ getter_name, ', '.join(arguments))
if (interface.name in ['Window', 'WorkerGlobalScope'] and
attribute.name == 'onerror'):
includes.add('bindings/v8/V8ErrorHandler.h')
arguments.append('V8EventListenerList::findOrCreateWrapper<V8ErrorHandler>(jsValue, true, info.GetIsolate())')
else:
arguments.append('V8EventListenerList::getEventListener(jsValue, true, ListenerFindOrCreate)')
- arguments.append(isolated_world)
elif v8_types.is_interface_type(idl_type) and not v8_types.array_type(idl_type):
# FIXME: should be able to eliminate WTF::getPtr in most or all cases
arguments.append('WTF::getPtr(cppValue)')
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698