Rework recent changes to LineInfo to be backward compatible.

Rework recent changes to LineInfo to be backward compatible.

Commit 1ecd06d39cbfa120709f1d986c25761e17f68e53 introduced a new getter
to the LineInfo class, breaking clients such as linter that use
LineInfo in an `implements` clause.

This CL reworks the change to be backward compatible.  It may be
reverted once we are ready to roll to a new major version of analyzer.

R=brianwilkerson@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/201e980fd29cf1777b3b74ece067fcd4d7534e0a

[Paul Berry, 2016-01-23 14:10:17]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[Brian Wilkerson, 2016-01-23 17:43:53]

LGTM

> ... breaking clients such as analyzer CLI ...

Did you mean 'linter'? 'analyzer_cli' has one class that implements LineInfo:

class MockLineInfo extends TypedMock implements LineInfo {}

but because TypedMock implements noSuchMethod, this change didn't break it. (It
did break a usage in 'linter', however.)

[scheglov, 2016-01-23 17:46:44]

lgtm

[Paul Berry, 2016-01-23 22:27:20]

On 2016/01/23 17:43:53, Brian Wilkerson wrote:
> LGTM
> 
> > ... breaking clients such as analyzer CLI ...
> 
> Did you mean 'linter'? 'analyzer_cli' has one class that implements LineInfo:
> 
> class MockLineInfo extends TypedMock implements LineInfo {}
> 
> but because TypedMock implements noSuchMethod, this change didn't break it.
(It
> did break a usage in 'linter', however.)

Whoops, my mistake--I misread the buildbot output.  The breakage was in linter.

[Paul Berry, 2016-01-23 22:27:45]

Description was changed from

==========
Rework recent changes to LineInfo to be backward compatible.

Commit 1ecd06d39cbfa120709f1d986c25761e17f68e53 introduced a new getter
to the LineInfo class, breaking clients such as analyzer CLI that use
LineInfo in an `implements` clause.

This CL reworks the change to be backward compatible.  It may be
reverted once we are ready to roll to a new major version of analyzer.
==========

to

==========
Rework recent changes to LineInfo to be backward compatible.

Commit 1ecd06d39cbfa120709f1d986c25761e17f68e53 introduced a new getter
to the LineInfo class, breaking clients such as linter that use
LineInfo in an `implements` clause.

This CL reworks the change to be backward compatible.  It may be
reverted once we are ready to roll to a new major version of analyzer.
==========

[Paul Berry, 2016-01-23 22:33:23]

Description was changed from

==========
Rework recent changes to LineInfo to be backward compatible.

Commit 1ecd06d39cbfa120709f1d986c25761e17f68e53 introduced a new getter
to the LineInfo class, breaking clients such as linter that use
LineInfo in an `implements` clause.

This CL reworks the change to be backward compatible.  It may be
reverted once we are ready to roll to a new major version of analyzer.
==========

to

==========
Rework recent changes to LineInfo to be backward compatible.

Commit 1ecd06d39cbfa120709f1d986c25761e17f68e53 introduced a new getter
to the LineInfo class, breaking clients such as linter that use
LineInfo in an `implements` clause.

This CL reworks the change to be backward compatible.  It may be
reverted once we are ready to roll to a new major version of analyzer.

R=brianwilkerson@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/201e980fd29cf1777b3b74ece067fcd4d7534e0a
==========

[Paul Berry, 2016-01-23 22:33:24]

Committed patchset #1 (id:1) manually as
201e980fd29cf1777b3b74ece067fcd4d7534e0a (presubmit successful).