Chromium Code Reviews| Index: third_party/WebKit/Source/core/editing/VisibleSelection.h |
| diff --git a/third_party/WebKit/Source/core/editing/VisibleSelection.h b/third_party/WebKit/Source/core/editing/VisibleSelection.h |
| index 2a678279ed7fe7e8c0241e62f86c6ca88c6c70fc..0d6b045f62e423f7600459fe2bb4d547f255d288 100644 |
| --- a/third_party/WebKit/Source/core/editing/VisibleSelection.h |
| +++ b/third_party/WebKit/Source/core/editing/VisibleSelection.h |
| @@ -40,8 +40,7 @@ namespace blink { |
| class LayoutPoint; |
| -// TODO(yosin) We should use capitalized name instead of |SEL_DEFAULT_AFFINITY|. |
| -const TextAffinity SEL_DEFAULT_AFFINITY = TextAffinity::Downstream; // NOLINT |
| +const TextAffinity SelDefaultAffinity = TextAffinity::Downstream; // NOLINT |
|
pdr.
2016/01/23 00:59:45
Should this be kSelDefaultAffinity?
pdr.
2016/01/23 01:01:22
Can we remove NOLINT too, and the //?
danakj
2016/01/23 01:10:50
It's complicated.. :) Current style is FooBar. Chr
|
| enum SelectionDirection { DirectionForward, DirectionBackward, DirectionRight, DirectionLeft }; |
| // Listener of |VisibleSelection| modification. |didChangeVisibleSelection()| |
| @@ -66,8 +65,8 @@ class CORE_TEMPLATE_CLASS_EXPORT VisibleSelectionTemplate { |
| public: |
| VisibleSelectionTemplate(); |
| VisibleSelectionTemplate(const PositionTemplate<Strategy>&, TextAffinity, bool isDirectional = false); |
| - VisibleSelectionTemplate(const PositionTemplate<Strategy>& base, const PositionTemplate<Strategy>& extent, TextAffinity = SEL_DEFAULT_AFFINITY, bool isDirectional = false); |
| - explicit VisibleSelectionTemplate(const EphemeralRangeTemplate<Strategy>&, TextAffinity = SEL_DEFAULT_AFFINITY, bool isDirectional = false); |
| + VisibleSelectionTemplate(const PositionTemplate<Strategy>& base, const PositionTemplate<Strategy>& extent, TextAffinity = SelDefaultAffinity, bool isDirectional = false); |
| + explicit VisibleSelectionTemplate(const EphemeralRangeTemplate<Strategy>&, TextAffinity = SelDefaultAffinity, bool isDirectional = false); |
| explicit VisibleSelectionTemplate(const VisiblePositionTemplate<Strategy>&, bool isDirectional = false); |
| VisibleSelectionTemplate(const VisiblePositionTemplate<Strategy>&, const VisiblePositionTemplate<Strategy>&, bool isDirectional = false); |