Fix naming style of constants named in SHOUT_CASE.

Fix naming style of constants named in SHOUT_CASE.

One of these really wants to be an enum, and then it stays SHOUT_CASE,
the others are consts, and should be UsualConstCase.

BUG=578344
Committed: https://crrev.com/d10c815bd8a66ea3413a867bf0b710b688f5d0ca
Cr-Commit-Position: refs/heads/master@{#371402}

[danakj, 2016-01-23 00:53:34]

danakj@chromium.org changed reviewers:
+ ojan@chromium.org

[danakj, 2016-01-23 00:53:49]

Description was changed from

==========
Fix naming style of constants named in SHOUT_CASE.

One of these really wants to be an enum, and then it stays SHOUT_CASE,
the others are consts, and should be UsualConstCase.

BUG=578344
==========

to

==========
Fix naming style of constants named in SHOUT_CASE.

One of these really wants to be an enum, and then it stays SHOUT_CASE,
the others are consts, and should be UsualConstCase.

BUG=578344
==========

[danakj, 2016-01-23 00:55:35]

danakj@chromium.org changed reviewers:
+ pdr@chromium.org

[danakj, 2016-01-23 00:55:36]

+pdr for platform/ and web/

[pdr., 2016-01-23 00:59:45]

LGTM.. err.. Lgtm

https://codereview.chromium.org/1625763002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/VisibleSelection.h (right):

https://codereview.chromium.org/1625763002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/VisibleSelection.h:43: const TextAffinity
SelDefaultAffinity = TextAffinity::Downstream; // NOLINT
Should this be kSelDefaultAffinity?

[pdr., 2016-01-23 01:01:22]

https://codereview.chromium.org/1625763002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/VisibleSelection.h (right):

https://codereview.chromium.org/1625763002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/VisibleSelection.h:43: const TextAffinity
SelDefaultAffinity = TextAffinity::Downstream; // NOLINT
On 2016/01/23 at 00:59:45, pdr wrote:
> Should this be kSelDefaultAffinity?

Can we remove NOLINT too, and the //?

[danakj, 2016-01-23 01:10:50]

https://codereview.chromium.org/1625763002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/VisibleSelection.h (right):

https://codereview.chromium.org/1625763002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/VisibleSelection.h:43: const TextAffinity
SelDefaultAffinity = TextAffinity::Downstream; // NOLINT
On 2016/01/23 01:01:22, pdr wrote:
> On 2016/01/23 at 00:59:45, pdr wrote:
> > Should this be kSelDefaultAffinity?

It's complicated.. :) Current style is FooBar. Chromium style is kFooBar. The
rewrite tool will make this kFooBar eventually, but I left it blinky style for
now?

> Can we remove NOLINT too, and the //?

probly! Done.

[danakj, 2016-01-23 01:11:32]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-01-23 01:11:32]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/1625763002/#ps20001
(title: "caps-consts: remove-nolint")

[danakj, 2016-01-23 01:11:38]

The CQ bit was checked by danakj@chromium.org

[pdr., 2016-01-23 01:12:14]

On 2016/01/23 at 01:10:50, danakj wrote:
>
https://codereview.chromium.org/1625763002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/editing/VisibleSelection.h (right):
> 
>
https://codereview.chromium.org/1625763002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/editing/VisibleSelection.h:43: const
TextAffinity SelDefaultAffinity = TextAffinity::Downstream; // NOLINT
> On 2016/01/23 01:01:22, pdr wrote:
> > On 2016/01/23 at 00:59:45, pdr wrote:
> > > Should this be kSelDefaultAffinity?
> 
> It's complicated.. :) Current style is FooBar. Chromium style is kFooBar. The
rewrite tool will make this kFooBar eventually, but I left it blinky style for
now?
> 
> > Can we remove NOLINT too, and the //?
> 
> probly! Done.

kTyLgtm

LGTM :)

[commit-bot: I haz the power, 2016-01-23 01:12:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1625763002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1625763002/20001

[commit-bot: I haz the power, 2016-01-23 01:53:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-23 01:53:11]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[danakj, 2016-01-25 22:47:34]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-25 22:52:21]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1625763002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1625763002/40001

[commit-bot: I haz the power, 2016-01-25 23:31:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-25 23:31:30]

Dry run: Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[danakj, 2016-01-25 23:48:34]

Patchset #3 (id:40001) has been deleted

[danakj, 2016-01-25 23:55:32]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-01-25 23:55:32]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/1625763002/#ps60001
(title: "caps-consts: unsigned")

[pdr., 2016-01-26 00:00:38]

On 2016/01/23 at 01:53:11, commit-bot wrote:
> Try jobs failed on following builders:
>   win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

Changing a short to an emum... how silly of us to forget to update the idl
codegen!

LGTM, nice yakshave.

[commit-bot: I haz the power, 2016-01-26 00:01:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1625763002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1625763002/60001

[danakj, 2016-01-26 00:13:50]

On 2016/01/26 00:00:38, pdr wrote:
> On 2016/01/23 at 01:53:11, commit-bot wrote:
> > Try jobs failed on following builders:
> >   win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
> 
> Changing a short to an emum... how silly of us to forget to update the idl
> codegen!
> 
> LGTM, nice yakshave.

Haha, yah. Amazingly MSVC seems to treat "5" as unsigned (which is what 5u
should be!), mind blown.

[danakj, 2016-01-26 00:40:35]

The CQ bit was unchecked by danakj@chromium.org

[danakj, 2016-01-26 01:16:22]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-01-26 01:17:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1625763002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1625763002/60001

[commit-bot: I haz the power, 2016-01-26 01:28:55]

Description was changed from

==========
Fix naming style of constants named in SHOUT_CASE.

One of these really wants to be an enum, and then it stays SHOUT_CASE,
the others are consts, and should be UsualConstCase.

BUG=578344
==========

to

==========
Fix naming style of constants named in SHOUT_CASE.

One of these really wants to be an enum, and then it stays SHOUT_CASE,
the others are consts, and should be UsualConstCase.

BUG=578344
==========

[commit-bot: I haz the power, 2016-01-26 01:28:56]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-01-26 01:30:03]

Description was changed from

==========
Fix naming style of constants named in SHOUT_CASE.

One of these really wants to be an enum, and then it stays SHOUT_CASE,
the others are consts, and should be UsualConstCase.

BUG=578344
==========

to

==========
Fix naming style of constants named in SHOUT_CASE.

One of these really wants to be an enum, and then it stays SHOUT_CASE,
the others are consts, and should be UsualConstCase.

BUG=578344

Committed: https://crrev.com/d10c815bd8a66ea3413a867bf0b710b688f5d0ca
Cr-Commit-Position: refs/heads/master@{#371402}
==========

[commit-bot: I haz the power, 2016-01-26 01:30:04]

Patchset 3 (id:??) landed as
https://crrev.com/d10c815bd8a66ea3413a867bf0b710b688f5d0ca
Cr-Commit-Position: refs/heads/master@{#371402}