Allocation sampling for paged/lo spaces

src/heap/incremental-marking.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_HEAP_INCREMENTAL_MARKING_H_
 #define V8_HEAP_INCREMENTAL_MARKING_H_
 
 #include "src/cancelable-task.h"
 #include "src/execution.h"
 #include "src/heap/heap.h"
@@ skipping 198 matching lines @@
 
   INLINE(static void MarkObject(Heap* heap, HeapObject* object));
 
   Heap* heap() const { return heap_; }
 
   IncrementalMarkingJob* incremental_marking_job() {
     return &incremental_marking_job_;
   }
 
  private:
-  class Observer : public InlineAllocationObserver {
+  class Observer : public AllocationObserver {
    public:
-    Observer(IncrementalMarking& incremental_marking, intptr_t step_size)
-        : InlineAllocationObserver(step_size),
+    Observer(IncrementalMarking& incremental_marking, Heap* heap,

[ofrobots, 2016/02/11 05:51:46]

`heap` parameter not used?

[mattloring, 2016/02/11 17:30:52]

Done.

+             intptr_t step_size)
+        : AllocationObserver(step_size),
           incremental_marking_(incremental_marking) {}
 
     void Step(int bytes_allocated, Address, size_t) override {
       incremental_marking_.Step(bytes_allocated,
                                 IncrementalMarking::GC_VIA_STACK_GUARD);
     }
 
    private:
     IncrementalMarking& incremental_marking_;
   };
@@ skipping 65 matching lines @@
   GCRequestType request_type_;
 
   IncrementalMarkingJob incremental_marking_job_;
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(IncrementalMarking);
 };
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_HEAP_INCREMENTAL_MARKING_H_