Allocation sampling for paged/lo spaces

test/cctest/heap/test-spaces.cc

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 779 matching lines @@
 
 static HeapObject* AllocateUnaligned(NewSpace* space, int size) {
   AllocationResult allocation = space->AllocateRawUnaligned(size);
   CHECK(!allocation.IsRetry());
   HeapObject* filler = NULL;
   CHECK(allocation.To(&filler));
   space->heap()->CreateFillerObjectAt(filler->address(), size);
   return filler;
 }
 
-class Observer : public InlineAllocationObserver {
+class Observer : public AllocationObserver {
  public:
-  explicit Observer(intptr_t step_size)
-      : InlineAllocationObserver(step_size), count_(0) {}
+  Observer(Heap* heap, intptr_t step_size)
+      : AllocationObserver(heap, step_size), count_(0) {}
 
   void Step(int bytes_allocated, Address, size_t) override { count_++; }
 
   int count() const { return count_; }
 
  private:
   int count_;
 };
 
 
-UNINITIALIZED_TEST(InlineAllocationObserver) {
+UNINITIALIZED_TEST(AllocationObserver) {
   v8::Isolate::CreateParams create_params;
   create_params.array_buffer_allocator = CcTest::array_buffer_allocator();
   v8::Isolate* isolate = v8::Isolate::New(create_params);
   {
     v8::Isolate::Scope isolate_scope(isolate);
     v8::HandleScope handle_scope(isolate);
     v8::Context::New(isolate)->Enter();
 
     Isolate* i_isolate = reinterpret_cast<Isolate*>(isolate);
 
     NewSpace* new_space = i_isolate->heap()->new_space();
 
-    Observer observer1(128);
+    Observer observer1(i_isolate->heap(), 128);
     new_space->AddInlineAllocationObserver(&observer1);
 
     // The observer should not get notified if we have only allocated less than
     // 128 bytes.
     AllocateUnaligned(new_space, 64);
     CHECK_EQ(observer1.count(), 0);
 
     // The observer should get called when we have allocated exactly 128 bytes.
     AllocateUnaligned(new_space, 64);
     CHECK_EQ(observer1.count(), 1);
 
     // Another >128 bytes should get another notification.
     AllocateUnaligned(new_space, 136);
     CHECK_EQ(observer1.count(), 2);
 
     // Allocating a large object should get only one notification.
     AllocateUnaligned(new_space, 1024);
     CHECK_EQ(observer1.count(), 3);
 
     // Allocating another 2048 bytes in small objects should get 16
     // notifications.
     for (int i = 0; i < 64; ++i) {
       AllocateUnaligned(new_space, 32);
     }
     CHECK_EQ(observer1.count(), 19);
 
     // Multiple observers should work.
-    Observer observer2(96);
+    Observer observer2(i_isolate->heap(), 96);
     new_space->AddInlineAllocationObserver(&observer2);
 
     AllocateUnaligned(new_space, 2048);
     CHECK_EQ(observer1.count(), 20);
     CHECK_EQ(observer2.count(), 1);
 
     AllocateUnaligned(new_space, 104);
     CHECK_EQ(observer1.count(), 20);
     CHECK_EQ(observer2.count(), 2);
 
@@ skipping 34 matching lines @@
   v8::Isolate* isolate = v8::Isolate::New(create_params);
   {
     v8::Isolate::Scope isolate_scope(isolate);
     v8::HandleScope handle_scope(isolate);
     v8::Context::New(isolate)->Enter();
 
     Isolate* i_isolate = reinterpret_cast<Isolate*>(isolate);
 
     NewSpace* new_space = i_isolate->heap()->new_space();
 
-    Observer observer1(512);
+    Observer observer1(i_isolate->heap(), 512);
     new_space->AddInlineAllocationObserver(&observer1);
-    Observer observer2(576);
+    Observer observer2(i_isolate->heap(), 576);
     new_space->AddInlineAllocationObserver(&observer2);
 
     for (int i = 0; i < 512; ++i) {
       AllocateUnaligned(new_space, 32);
     }
 
     new_space->RemoveInlineAllocationObserver(&observer1);
     new_space->RemoveInlineAllocationObserver(&observer2);
 
     CHECK_EQ(observer1.count(), 32);
     CHECK_EQ(observer2.count(), 28);
   }
   isolate->Dispose();

[ofrobots, 2016/01/23 16:16:31]

Add tests for old space, lo space, map space, code space.

[mattloring, 2016/01/26 00:42:48]

Getting to these next, just wanted to hammer out the structure of these changes
first.

 }
 
 }  // namespace internal
 }  // namespace v8