Allocation sampling for paged/lo spaces

src/heap/spaces-inl.h

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_HEAP_SPACES_INL_H_
 #define V8_HEAP_SPACES_INL_H_
 
 #include "src/heap/incremental-marking.h"
 #include "src/heap/spaces.h"
 #include "src/isolate.h"
@@ skipping 407 matching lines @@
     return object;
   }
 
   return AllocationResult::Retry(identity());
 }
 
 
 AllocationResult PagedSpace::AllocateRaw(int size_in_bytes,
                                          AllocationAlignment alignment) {
 #ifdef V8_HOST_ARCH_32_BIT
-  return alignment == kDoubleAligned
-             ? AllocateRawAligned(size_in_bytes, kDoubleAligned)
-             : AllocateRawUnaligned(size_in_bytes);
+  AllocationResult result =
+      alignment == kDoubleAligned
+          ? AllocateRawAligned(size_in_bytes, kDoubleAligned)
+          : AllocateRawUnaligned(size_in_bytes);
 #else
-  return AllocateRawUnaligned(size_in_bytes);
+  AllocationResult result = AllocateRawUnaligned(size_in_bytes);
 #endif
+  if (!result.IsRetry()) {
+    Object* obj = result.ToObjectChecked();
+    if (obj->IsHeapObject()) {

[ofrobots, 2016/01/23 16:16:31]

Why is this check necessary here?

[ofrobots, 2016/01/26 00:38:25]

*bump*

[mattloring, 2016/01/26 00:42:48]

An Object can be an Smi or a HeapObject so I check that here. Is the check known
to be unnecessary in this instance?

[ofrobots, 2016/01/26 15:47:15]

We just allocated an object on the heap; so this check should not be necessary I
think. 

+      HeapObject* heap_obj = static_cast<HeapObject*>(obj);
+      for (int i = 0; i < allocation_observers_.length(); ++i) {
+        AllocationObserver* o = allocation_observers_[i];
+        o->AllocationStep(size_in_bytes, heap_obj->address(), size_in_bytes);
+      }
+    }
+  }
+  return result;
 }
 
 
 // -----------------------------------------------------------------------------
 // NewSpace
 
 
 AllocationResult NewSpace::AllocateRawAligned(int size_in_bytes,
                                               AllocationAlignment alignment) {
   Address top = allocation_info_.top();
@@ skipping 100 matching lines @@
     other->allocation_info_.Reset(nullptr, nullptr);
     return true;
   }
   return false;
 }
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_HEAP_SPACES_INL_H_