Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(941)

Issue 1625733002: Remove obsolete test (Closed)

Created:
4 years, 11 months ago by hausner
Modified:
4 years, 10 months ago
Reviewers:
gbracha
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove obsolete test built-in identifiers are no longer permitted as prefixes. TBR=gbracha BUG=6970 Committed: https://github.com/dart-lang/sdk/commit/82735da84dbc306ab3667aa1c9317ef8c960a89b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -219 lines) Patch
D tests/language/built_in_identifier_prefix_test.dart View 1 chunk +0 lines, -216 lines 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +0 lines, -1 line 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
hausner
Committed patchset #1 (id:1) manually as 82735da84dbc306ab3667aa1c9317ef8c960a89b (presubmit successful).
4 years, 11 months ago (2016-01-23 00:00:25 UTC) #4
hausner
4 years, 11 months ago (2016-01-23 00:00:35 UTC) #5
gbracha
4 years, 10 months ago (2016-01-26 02:30:38 UTC) #6
Message was sent while issue was closed.
lgtm. I don't think this test was ever valid, but it's moot now.

Powered by Google App Engine
This is Rietveld 408576698