third_party/WebKit/Source/core/layout/svg/SVGTextChunkBuilder.cpp - Issue 1625683003: [Line Layout API] Some harder SVGTextLayoutEngine changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/SVGTextChunkBuilder.cpp

Issue 1625683003: [Line Layout API] Some harder SVGTextLayoutEngine changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@3_api_easy_svg

Patch Set: readd null check with new isNull() method on LineLayoutItem Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/line/InlineBox.h ('k') | third_party/WebKit/Source/core/layout/svg/SVGTextLayoutEngine.cpp » ('j') | third_party/WebKit/Source/core/svg/SVGTextContentElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/SVGTextChunkBuilder.cpp

diff --git a/third_party/WebKit/Source/core/layout/svg/SVGTextChunkBuilder.cpp b/third_party/WebKit/Source/core/layout/svg/SVGTextChunkBuilder.cpp

index e2c3bd74df1a988902f58cab8a5503a995452e61..f4f7366d201f1bf3bfb7c84a27303cdb7f5b5838 100644

--- a/third_party/WebKit/Source/core/layout/svg/SVGTextChunkBuilder.cpp

+++ b/third_party/WebKit/Source/core/layout/svg/SVGTextChunkBuilder.cpp

@@ -186,7 +186,7 @@ void SVGTextChunkBuilder::handleTextChunk(BoxListConstIterator boxStart, BoxList

// Handle 'lengthAdjust' property.

float desiredTextLength = 0;

SVGLengthAdjustType lengthAdjust = SVGLengthAdjustUnknown;

- if (SVGTextContentElement* textContentElement = SVGTextContentElement::elementFromLayoutObject(textLineLayout.parent())) {

+ if (SVGTextContentElement* textContentElement = SVGTextContentElement::elementFromLineLayoutItem(textLineLayout.parent())) {

lengthAdjust = textContentElement->lengthAdjust()->currentValue()->enumValue();

SVGLengthContext lengthContext(textContentElement);