Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: third_party/WebKit/Source/core/layout/api/LineLayoutItem.h

Issue 1625683003: [Line Layout API] Some harder SVGTextLayoutEngine changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@3_api_easy_svg
Patch Set: readd null check with new isNull() method on LineLayoutItem Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/api/LineLayoutItem.h
diff --git a/third_party/WebKit/Source/core/layout/api/LineLayoutItem.h b/third_party/WebKit/Source/core/layout/api/LineLayoutItem.h
index 3dc3a64a90423e9e26b9ff7f8c21561d2e9a85ae..92f49929e1aa41d3586930d3d5d50c50b9c7f09e 100644
--- a/third_party/WebKit/Source/core/layout/api/LineLayoutItem.h
+++ b/third_party/WebKit/Source/core/layout/api/LineLayoutItem.h
@@ -44,6 +44,12 @@ public:
// https://crbug.com/499321
operator LayoutObject*() const { return m_layoutObject; }
+ // TODO(dgrogan): Remove this when we replace the operator above with UnspecifiedBoolType.
+ bool isNull() const
+ {
+ return !m_layoutObject;
+ }
+
bool isEqual(const LayoutObject* layoutObject) const
{
return m_layoutObject == layoutObject;
@@ -269,6 +275,11 @@ public:
return m_layoutObject->isSVGInlineText();
}
+ bool isSVGText() const
+ {
+ return m_layoutObject->isSVGText();
+ }
+
bool isSVGTextPath() const
{
return m_layoutObject->isSVGTextPath();

Powered by Google App Engine
This is Rietveld 408576698