Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 1625643003: Don't enable shader extenstions in WebGL 2 when they are already core. (Closed)

Created:
4 years, 11 months ago by Zhenyao Mo
Modified:
4 years, 11 months ago
Reviewers:
bajones, nodir
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't enable shader extenstions in WebGL 2 when they are already core. BUG=295792 TEST=webgl2_conformance R=bajones@chromium.org Committed: https://crrev.com/8bc9fcfe77e1ba451a39042939954101e9e59863 Cr-Commit-Position: refs/heads/master@{#371627}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -35 lines) Patch
M content/test/gpu/gpu_tests/webgl2_conformance_expectations.py View 2 chunks +1 line, -4 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 3 chunks +33 lines, -31 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
Zhenyao Mo
bajones: PTAL
4 years, 11 months ago (2016-01-23 00:17:48 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1625643003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1625643003/1
4 years, 11 months ago (2016-01-23 00:18:02 UTC) #3
bajones
LGTM
4 years, 11 months ago (2016-01-23 00:32:09 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/170385)
4 years, 11 months ago (2016-01-23 00:54:58 UTC) #6
nodir
On 2016/01/23 00:54:58, commit-bot: I haz the power wrote: > Dry run: Try jobs failed ...
4 years, 11 months ago (2016-01-23 01:27:15 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1625643003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1625643003/1
4 years, 11 months ago (2016-01-23 01:30:06 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/170429)
4 years, 11 months ago (2016-01-23 03:03:49 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1625643003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1625643003/20001
4 years, 11 months ago (2016-01-26 20:50:56 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-26 22:10:14 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1625643003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1625643003/20001
4 years, 11 months ago (2016-01-26 22:54:32 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-26 23:09:31 UTC) #19
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 23:11:06 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8bc9fcfe77e1ba451a39042939954101e9e59863
Cr-Commit-Position: refs/heads/master@{#371627}

Powered by Google App Engine
This is Rietveld 408576698