Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 16256023: Move systemInfo.memory API out of experimental namespace. (Closed)

Created:
7 years, 6 months ago by Tim Song
Modified:
7 years, 6 months ago
CC:
chromium-reviews, Aaron Boodman, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Move systemInfo.memory API out of experimental namespace. As a consequence, we move systemInfo.memory from using the experimental API permissions to its own permission based on an extension whitelist. BUG=237297 TEST=updated and passed unit tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=204570

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Resolved merge conflict from new commits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -42 lines) Patch
M chrome/browser/extensions/activity_log/api_name_constants.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/system_info_memory/memory_info_provider.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/system_info_memory/memory_info_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/system_info_memory/memory_info_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/system_info_memory/system_info_memory_api.h View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/system_info_memory/system_info_memory_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/system_info_memory/system_info_memory_apitest.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_function_histogram_value.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/api.gyp View 1 chunk +1 line, -1 line 0 comments Download
D chrome/common/extensions/api/experimental_system_info_memory.idl View 1 chunk +0 lines, -21 lines 0 comments Download
A + chrome/common/extensions/api/system_info_memory.idl View 1 chunk +1 line, -1 line 0 comments Download
D chrome/common/extensions/docs/templates/public/apps/experimental_systemInfo_memory.html View 1 chunk +0 lines, -1 line 0 comments Download
A chrome/common/extensions/docs/templates/public/apps/systemInfo_memory.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/permissions/api_permission.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/permissions/chrome_api_permissions.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/extensions/api_test/systeminfo/memory/manifest.json View 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/systeminfo/memory/test_memory_api.js View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Tim Song
This changelist is very similar to the one you reviewed earlier, moving the systemInfo.cpu API ...
7 years, 6 months ago (2013-06-03 21:42:12 UTC) #1
asargent_no_longer_on_chrome
Something seems to have gone wrong with the uploading process - on each file when ...
7 years, 6 months ago (2013-06-03 22:21:21 UTC) #2
Tim Song
On 2013/06/03 22:21:21, Antony Sargent wrote: > Something seems to have gone wrong with the ...
7 years, 6 months ago (2013-06-03 22:56:50 UTC) #3
asargent_no_longer_on_chrome
lgtm
7 years, 6 months ago (2013-06-03 23:40:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tengs@chromium.org/16256023/2002
7 years, 6 months ago (2013-06-04 00:32:24 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=6532
7 years, 6 months ago (2013-06-04 00:42:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tengs@chromium.org/16256023/2002
7 years, 6 months ago (2013-06-04 01:02:14 UTC) #7
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=6539
7 years, 6 months ago (2013-06-04 01:13:33 UTC) #8
Tim Song
+isherman I forgot to get your approval for histograms.xml yet again. Please take a look.
7 years, 6 months ago (2013-06-04 02:15:44 UTC) #9
Alexei Svitkine (slow)
histograms.xml lgtm
7 years, 6 months ago (2013-06-05 19:50:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tengs@chromium.org/16256023/2002
7 years, 6 months ago (2013-06-05 19:51:46 UTC) #11
commit-bot: I haz the power
Failed to apply patch for chrome/browser/extensions/extension_function_histogram_value.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 6 months ago (2013-06-05 19:51:53 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tengs@chromium.org/16256023/24001
7 years, 6 months ago (2013-06-05 21:02:48 UTC) #13
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 6 months ago (2013-06-06 01:53:50 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tengs@chromium.org/16256023/24001
7 years, 6 months ago (2013-06-06 18:08:14 UTC) #15
commit-bot: I haz the power
7 years, 6 months ago (2013-06-06 20:10:08 UTC) #16
Message was sent while issue was closed.
Change committed as 204570

Powered by Google App Engine
This is Rietveld 408576698