content/browser/indexed_db/leveldb/leveldb_transaction.cc - Issue 16256014: IndexedDB: Convert decoding functions to pass StringPieces vs. pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/indexed_db/leveldb/leveldb_transaction.cc

Issue 16256014: IndexedDB: Convert decoding functions to pass StringPieces vs. pointers (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/indexed_db/leveldb/leveldb_slice.h ('K') | « content/browser/indexed_db/leveldb/leveldb_transaction.h ('k') | content/browser/indexed_db/leveldb/leveldb_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/indexed_db/leveldb/leveldb_transaction.cc

diff --git a/content/browser/indexed_db/leveldb/leveldb_transaction.cc b/content/browser/indexed_db/leveldb/leveldb_transaction.cc

index a8b3a3dbb06df0168262b4344403b6f152fcdf59..5b8ce0237462729f5b9e6e699a3e5777c22132a6 100644

--- a/content/browser/indexed_db/leveldb/leveldb_transaction.cc

+++ b/content/browser/indexed_db/leveldb/leveldb_transaction.cc

@@ -78,7 +78,7 @@ void LevelDBTransaction::Remove(const LevelDBSlice& key) {

}

bool LevelDBTransaction::Get(const LevelDBSlice& key,

- std::vector<char>& value,

+ std::string* value,

bool& found) {

found = false;

DCHECK(!finished_);

@@ -88,7 +88,7 @@ bool LevelDBTransaction::Get(const LevelDBSlice& key,

if (node->deleted)

return true;

- value = node->value;

+ *value = std::string(node->value.begin(), node->value.end());

found = true;

return true;

}

@@ -170,7 +170,7 @@ void LevelDBTransaction::TreeIterator::Next() {

DCHECK(transaction_->comparator_->Compare(LevelDBSlice((*iterator_)->key),

LevelDBSlice(key_)) >

0);

- (void) transaction_;

+ (void)transaction_;

key_ = (*iterator_)->key;

}