IndexedDB: Convert decoding functions to pass StringPieces vs. pointers

content/browser/indexed_db/leveldb/leveldb_database.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/indexed_db/leveldb/leveldb_database.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/logging.h"
@@ skipping 224 matching lines @@
   const leveldb::Status s = db_->Delete(write_options, MakeSlice(key));
   if (s.ok())
     return true;
   if (s.IsNotFound())
     return false;
   LOG(ERROR) << "LevelDB remove failed: " << s.ToString();
   return false;
 }
 
 bool LevelDBDatabase::Get(const LevelDBSlice& key,
-                          std::vector<char>& value,
+                          std::string* value,
                           bool& found,
                           const LevelDBSnapshot* snapshot) {
   found = false;
-  std::string result;
   leveldb::ReadOptions read_options;
   read_options.verify_checksums = true;  // TODO(jsbell): Disable this if the
                                          // performance impact is too great.
   read_options.snapshot = snapshot ? snapshot->snapshot_ : 0;
 
-  const leveldb::Status s = db_->Get(read_options, MakeSlice(key), &result);
+  const leveldb::Status s = db_->Get(read_options, MakeSlice(key), value);
   if (s.ok()) {
     found = true;
-    value.clear();
-    value.insert(value.end(), result.begin(), result.end());
     return true;
   }
   if (s.IsNotFound())
     return true;
   LOG(ERROR) << "LevelDB get failed: " << s.ToString();
   return false;
 }
 
 bool LevelDBDatabase::Write(LevelDBWriteBatch& write_batch) {
   leveldb::WriteOptions write_options;
@@ skipping 83 matching lines @@
   if (!i)  // TODO(jsbell): Double check if we actually need to check this.
     return scoped_ptr<LevelDBIterator>();
   return scoped_ptr<LevelDBIterator>(new IteratorImpl(i.Pass()));
 }
 
 const LevelDBComparator* LevelDBDatabase::Comparator() const {
   return comparator_;
 }
 
 }  // namespace content