Issue 16256004: Revert 203217 "Revert 202987 "Reorder the NativeViews attached t..."

Issue 16256004: Revert 203217 "Revert 202987 "Reorder the NativeViews attached t..." (Closed)

Created:
7 years, 6 months ago by Avi (use Gerrit)

Modified:
7 years, 6 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 203217 "Revert 202987 "Reorder the NativeViews attached t..." I reverted it yesterday because I thought it was burning the Aura tree. It turned out to be innocent so I'm putting it back. TBR=avi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203402

Patch Set 1 #

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+191 lines, -19 lines)			Patch
M	trunk/src/ui/aura/window.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	trunk/src/ui/aura/window.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	trunk/src/ui/views/controls/native/native_view_host_aura.cc	View	2 chunks	+7 lines, -1 line	0 comments	Download
M	trunk/src/ui/views/controls/native/native_view_host_aura_unittest.cc	View	3 chunks	+22 lines, -0 lines	0 comments	Download
M	trunk/src/ui/views/view.h	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	trunk/src/ui/views/view.cc	View	3 chunks	+18 lines, -10 lines	0 comments	Download
A +	trunk/src/ui/views/view_constants_aura.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/ui/views/view_constants_aura.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	trunk/src/ui/views/view_unittest.cc	View	2 chunks	+62 lines, -1 line	0 comments	Download
M	trunk/src/ui/views/views.gyp	View	5 chunks	+8 lines, -0 lines	0 comments	Download
M	trunk/src/ui/views/widget/desktop_aura/desktop_native_widget_aura.h	View	3 chunks	+6 lines, -0 lines	0 comments	Download
M	trunk/src/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc	View	3 chunks	+8 lines, -0 lines	0 comments	Download
M	trunk/src/ui/views/widget/native_widget_aura.h	View	3 chunks	+6 lines, -0 lines	0 comments	Download
M	trunk/src/ui/views/widget/native_widget_aura.cc	View	3 chunks	+8 lines, -0 lines	0 comments	Download
M	trunk/src/ui/views/widget/native_widget_aura_unittest.cc	View	3 chunks	+11 lines, -11 lines	0 comments	Download
M	trunk/src/ui/views/widget/native_widget_private.h	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	trunk/src/ui/views/widget/native_widget_win.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	trunk/src/ui/views/widget/native_widget_win.cc	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	trunk/src/ui/views/widget/widget.h	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	trunk/src/ui/views/widget/widget.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
A +	trunk/src/ui/views/widget/window_reorderer.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/ui/views/widget/window_reorderer.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	trunk/src/ui/views/widget/window_reorderer_unittest.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

pkotwicz

Out of interest, what did the issue end up being? I am asking because in ...

7 years, 6 months ago (2013-05-31 15:19:39 UTC) #3

Avi (use Gerrit)

7 years, 6 months ago (2013-05-31 15:20:25 UTC) #4

Message was sent while issue was closed.

On 2013/05/31 15:19:39, pkotwicz wrote:
> Out of interest, what did the issue end up being? I am asking because in a
> convenient world the issue you investigated yesterday would be the same issue
as
> https://code.google.com/p/chromium/issues/detail?id=244949
> 
> I am asking in the off chance that it is the same issue.

Wish I knew. Blink rolled and magically the bot went green.

Expand Messages | Collapse Messages