Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 1625573003: On ES or Core profile, we should be able to disable vertex attrib 0. (Closed)

Created:
4 years, 11 months ago by Zhenyao Mo
Modified:
4 years, 11 months ago
Reviewers:
vmiura
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

On ES or Core profile, we should be able to disable vertex attrib 0. BUG=429053 TEST=gpu_unitests R=vmiura@chromium.org Committed: https://crrev.com/f9d25cd702bd6b744eb2e2b605c2000426e69531 Cr-Commit-Position: refs/heads/master@{#371352}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -17 lines) Patch
M gpu/command_buffer/service/context_state.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 4 chunks +10 lines, -11 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc View 1 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1625573003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1625573003/1
4 years, 11 months ago (2016-01-22 21:35:32 UTC) #2
vmiura
Could you also make the same change in ContextState::RestoreVertexAttribArrays?
4 years, 11 months ago (2016-01-22 21:37:30 UTC) #3
vmiura
Sorry, one more in GLES2DecoderImpl::RestoreStateForAttrib. Thanks
4 years, 11 months ago (2016-01-22 21:39:56 UTC) #4
Zhenyao Mo
Thanks for pointing them out. Revised. Please take another look.
4 years, 11 months ago (2016-01-22 22:08:50 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1625573003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1625573003/20001
4 years, 11 months ago (2016-01-22 22:09:05 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-22 23:55:44 UTC) #9
vmiura
lgtm, thanks!
4 years, 11 months ago (2016-01-25 22:25:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1625573003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1625573003/20001
4 years, 11 months ago (2016-01-25 22:28:07 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-25 23:57:44 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 00:00:56 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f9d25cd702bd6b744eb2e2b605c2000426e69531
Cr-Commit-Position: refs/heads/master@{#371352}

Powered by Google App Engine
This is Rietveld 408576698