Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 1625543002: Use the explicit string 'void' to refer to void in summaries. (Closed)

Created:
4 years, 11 months ago by Paul Berry
Modified:
4 years, 11 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use the explicit string 'void' to refer to void in summaries. Previously we used a null EntityRef as a special case to mean "void". This saved a tiny amount of space in the summary file, but it's not worth it because (a) it will complicate some error handling scenarios, and (b) it would be more worthwhile to use a null EntityRef to represent implicit types. Both (a) and (b) will be addressed in future CLs. This CL changes "void" so that it's serialized as though it were defined in the defining compilation unit of each library. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/d1f3290c388676ac63d4254ad9eb5a778bfea3d9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -96 lines) Patch
M pkg/analyzer/lib/src/summary/format.dart View 14 chunks +28 lines, -32 lines 0 comments Download
M pkg/analyzer/lib/src/summary/prelink.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/resynthesize.dart View 4 chunks +8 lines, -15 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 5 chunks +4 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_elements.dart View 8 chunks +18 lines, -19 lines 0 comments Download
M pkg/analyzer/test/src/summary/summary_common.dart View 5 chunks +11 lines, -4 lines 0 comments Download
M pkg/analyzer/tool/summary/idl.dart View 7 chunks +14 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 11 months ago (2016-01-22 18:03:20 UTC) #2
scheglov
LGTM
4 years, 11 months ago (2016-01-22 18:07:07 UTC) #3
Paul Berry
4 years, 11 months ago (2016-01-22 18:26:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d1f3290c388676ac63d4254ad9eb5a778bfea3d9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698