Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 162553005: DevTools: Focus console on Ctrl+` (Closed)

Created:
6 years, 10 months ago by apavlov
Modified:
6 years, 10 months ago
Reviewers:
eustas, vsevik
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: Focus visible console on Ctrl+` Currently, the hidden console is shown on Ctrl+`, but it is not focused if it is visible. This patch handles the focusing part. R=eustas@chromium.org, eustas, vsevik BUG=144943 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167592

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M Source/devtools/front_end/ConsoleView.js View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/devtools/front_end/inspector.js View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
apavlov
6 years, 10 months ago (2014-02-21 12:08:32 UTC) #1
eustas
lgtm
6 years, 10 months ago (2014-02-21 12:22:01 UTC) #2
apavlov
The CQ bit was checked by apavlov@chromium.org
6 years, 10 months ago (2014-02-21 12:23:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/apavlov@chromium.org/162553005/1
6 years, 10 months ago (2014-02-21 12:23:15 UTC) #4
apavlov
6 years, 10 months ago (2014-02-21 12:27:57 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r167592 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698