Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 1625473004: Copy 'ConstructorName.staticElement' in ConstantAstCloner. (Closed)

Created:
4 years, 11 months ago by scheglov
Modified:
4 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Copy 'ConstructorName.staticElement' in ConstantAstCloner. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/0025a8383e17dcd5a9b9118da0e9500ec4463e0a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M pkg/analyzer/lib/src/generated/constant.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/testing/element_factory.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 11 months ago (2016-01-22 21:39:48 UTC) #1
Brian Wilkerson
LGTM
4 years, 11 months ago (2016-01-22 21:50:43 UTC) #2
scheglov
4 years, 11 months ago (2016-01-22 23:19:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0025a8383e17dcd5a9b9118da0e9500ec4463e0a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698